Skip to content

SAST team should not be suggested as reviewers for sast-rules

Craig Smith requested to merge craigmsmith-remove-sast-team-from-sast-bot-for-rules into master

Why is this change being made?

The @gitlab-org/secure/static-analysis team have time-sensitive issues relating to 17.0 SAST consolidations from language-specific... (gitlab-org&13050) that must be completed to successfully deliver the %17.0 commitments. The team are struggling to meet this commitment because of the review load placed on them by changes to the semgrep rules in https://gitlab.com/gitlab-org/security-products/sast-rules.

This MR removes @craigmsmith, @adamcohen, @jleasure and @hyan3 as reviewers for sast-rules so dangerBot no longer suggests them.

Author and Reviewer Checklist

Please verify the check list and ensure to tick them off before the MR is merged.

  • Provided a concise title for this Merge Request (MR)
  • Added a description to this MR explaining the reasons for the proposed change, per say why, not just what
    • Copy/paste the Slack conversation to document it for later, or upload screenshots. Verify that no confidential data is added, and the content is SAFE
  • Assign reviewers for this MR to the correct Directly Responsible Individual/s (DRI)
    • If the DRI for the page/s being updated isn’t immediately clear, then assign it to one of the people listed in the Maintained by section on the page being edited
    • If your manager does not have merge rights, please ask someone to merge it AFTER it has been approved by your manager in #mr-buddies
    • The when to get approval handbook section explains the workflow in more detail
  • For transparency, share this MR with the audience that will be impacted.
    • Team: For changes that affect your direct team, share in your group Slack channel
    • Department: If the update affects your department, share the MR in your department Slack channel
    • Company: If the update affects all (or the majority of) GitLab team members, post an update in #whats-happening-at-gitlab linking to this MR

Merge request reports