Add Sheldon Led as a FE maintainer for CustomersDot
Manager Justification
It's hard to specify hard requirements for becoming a maintainer, which is why the documentation consists of flexible guidelines. Reviewers are encouraged to think of their eligibility for maintainership in the terms of "I could be ready at any time to be a maintainer as long as it is justified".
-
The MRs reviewed by the candidate consistently make it through maintainer review without significant additionally required changes. -
The MRs authored by the candidate consistently make it through reviewer and maintainer review without significant required changes. -
Followed the additional maintainer process steps for customers-gitlab-com
Trainee Maintainer Issue: #34360 (closed). Summary justification:
- Working on
CustomersDot
project for 2+ years (first MR) - Reviewed and approved 50+ MRs with a 80% merged as-is success rate across recent reviews.
- Reviews have covered several areas of the codebase in addition to frontend, including backend, mailers, documentation, tooling, etc.
- Since the Trainee Maintainer Issue was opened (2023-07-11), most reviews were lightweight, a few stand out as less trivial:
- https://gitlab.com/gitlab-org/customers-gitlab-com/-/merge_requests/7803 | Summary: #34360 (comment 1467413036)
- https://gitlab.com/gitlab-org/customers-gitlab-com/-/merge_requests/7963 | Summary: #34360 (comment 1524879029)
- https://gitlab.com/gitlab-org/customers-gitlab-com/-/merge_requests/8131 | Summary: #34360 (comment 1529900167)
- https://gitlab.com/gitlab-org/customers-gitlab-com/-/merge_requests/8282 | Summary: #34360 (comment 1662815337)
Before Merging (Manager Tasks)
-
Close any relevant trainee maintainer issues with a comment indicating that this merge request is being created, as (they are no longer required to become a maintainer). -
Mention the maintainers from the given specialty and ask them to provide feedback to the manager directly. -
Leave this merge request open for 1 week, to give the maintainers time to provide feedback. -
Ensure we have at least 2 approvals from existing maintainers.
Once This MR is Merged
-
Create an access request for maintainer access to gitlab-org/customers-gitlab-com
. -
Join theN/A[at]frontend-maintainers
slack group -
Ask the maintainers in your group to invite you to any gitlab-org/customers-gitlab-com
maintainer-specific meeting if one exists. -
Let a maintainer add you toN/Agitlab-org/maintainers/frontend
withOwner
access level. -
Announce it everywhere -
Keep reviewing, start merging 🤘 😎 🤘
Edited by Sheldon Led