Skip to content

Minimal change required for sast-rules maintainers to also be picked as reviewers

Jayson Salazar Rodriguez requested to merge jsalazar-sast-rules-add-maintainers-as-reviewers-projects-yml into master

Why is this change being made?

This MR finalizes the Vulnerability Research Team's tests in order to get Reviewer Roulette properly working on the https://gitlab.com/gitlab-org/security-products/sast-rules repository.

This MR is related to !133044 (merged) and is aimed at duplicating the project's maintainers so we can implement a workflow where a contributor and a reviewer get the MR ready and a maintainer gives the final OK as discussed today in our team call and in gitlab-org/gitlab#439694 (closed)

image

Author and Reviewer Checklist

Please verify the check list and ensure to tick them off before the MR is merged.

  • Provided a concise title for this Merge Request (MR)
  • Added a description to this MR explaining the reasons for the proposed change, per say why, not just what
    • Copy/paste the Slack conversation to document it for later, or upload screenshots. Verify that no confidential data is added, and the content is SAFE
  • Assign reviewers for this MR to the correct Directly Responsible Individual/s (DRI)
    • If the DRI for the page/s being updated isn’t immediately clear, then assign it to one of the people listed in the Maintained by section on the page being edited
    • If your manager does not have merge rights, please ask someone to merge it AFTER it has been approved by your manager in #mr-buddies
    • The when to get approval handbook section explains the workflow in more detail
  • For transparency, share this MR with the audience that will be impacted.
    • Team: For changes that affect your direct team, share in your group Slack channel
    • Department: If the update affects your department, share the MR in your department Slack channel
    • Company: If the update affects all (or the majority of) GitLab team members, post an update in #whats-happening-at-gitlab linking to this MR
Edited by Jayson Salazar Rodriguez

Merge request reports