Skip to content

Change Jason Goodman from Trainee to GitLab BE Maintainer

Manager Justification

It's hard to specify hard requirements for becoming a maintainer, which is why the documentation consists of flexible guidelines. Reviewers are encouraged to think of their eligibility for maintainership in the terms of "I could be ready at any time to be a maintainer as long as my work as an author and reviewer is consistent with other maintainers".

  • The MRs reviewed by the candidate consistently make it through maintainer review without significant additionally required changes.
  • The MRs authored by the candidate consistently make it through reviewer and maintainer review without significant required changes.

@jagood, senior backend engineer, has been with GitLab for 4 years. He currently has backend maintainer status on the CustomersDot (customers-gitlab-com) project, and he's been working on attaining backend maintainership for the GitLab project.

His progress can be found in this Trainee Maintainer Issue: #13344 (closed)

Jason:

  1. has 218 MRs reviewed
  2. provides very thorough reviews where he:
    1. asks excellent disambiguating questions
    2. distinguishes between blocking and non-blocking suggestions for efficient review cycles
    3. raises broader concerns that an MR might be missing or introducing
    4. pushes for iteration and boring solutions
  3. has multiple back to back MRs with minor suggestions or no suggestions from the reviewing maintainer

Before Merging (Manager Tasks)

  • Close any relevant trainee maintainer issues with a comment indicating that this merge request is being created, as (they are no longer required to become a maintainer).
  • Mention the maintainers from the given specialty with the template below.
  • Leave this merge request open for 1 week, to give the maintainers time to provide feedback.
  • Ensure we have at least 2 approvals from existing maintainers.
Template call to action
SPECIALITY Maintainers, please review this proposal to make TRAINEE maintainer of PROJECT. 

* If you have blocking feedback adhering [to the documentation](https://about.gitlab.com/handbook/engineering/workflow/code-review/#how-to-become-a-project-maintainer) please share it with me via Slack.
* If you are in agreement, and can vouch for this proposal, please approve.

After 1 week, if there is no blocking feedback and at least 2 approvals, I will merge this MR.

Once This MR is Merged

  1. Join the #backend_maintainers Slack channel
  2. Ask the maintainers in your group to invite you to any maintainer-specific meeting if one exists.
  3. Let a maintainer add you to @gitlab-org/maintainers/rails-backend with Owner access level.
  4. Announce it everywhere
  5. Familiarize yourself with documentation for Merging a merge request
  6. Keep reviewing, start merging 🤘 😎 🤘
Edited by Jason Goodman

Merge request reports