Skip to content

Remove stage values from category file entries

Sam Kerr requested to merge stkerr-remove-stage-from-category-file-entries into master

Why is this change being made?

There are currently two files where the category<-->stage relationship is defined, in both categories.yml and stages.yml. This leads to duplication of data entry and confusion when they mismatch. This MR removes the information from categories.yml in favor of using stages.yml as the SSOT.

This is a follow-on MR from !131686 (merged) which was partially reverted since the buyer-experience repo needed to be updated first. The logic for only reading stages.yml

The buyer experience repo was updated in Dont use stage value from categories in favor o... (gitlab-com/marketing/digital-experience/buyer-experience!3313 - merged)

Author and Reviewer Checklist

Please verify the check list and ensure to tick them off before the MR is merged.

  • Provided a concise title for this Merge Request (MR)
  • Added a description to this MR explaining the reasons for the proposed change, per say why, not just what
    • Copy/paste the Slack conversation to document it for later, or upload screenshots. Verify that no confidential data is added, and the content is SAFE
  • Assign reviewers for this MR to the correct Directly Responsible Individual/s (DRI)
    • If the DRI for the page/s being updated isn’t immediately clear, then assign it to one of the people listed in the Maintained by section on the page being edited
    • If your manager does not have merge rights, please ask someone to merge it AFTER it has been approved by your manager in #mr-buddies
    • The when to get approval handbook section explains the workflow in more detail
  • For transparency, share this MR with the audience that will be impacted.
    • Team: For changes that affect your direct team, share in your group Slack channel
    • Department: If the update affects your department, share the MR in your department Slack channel
    • Company: If the update affects all (or the majority of) GitLab team members, post an update in #whats-happening-at-gitlab linking to this MR
Edited by Sam Kerr

Merge request reports