Replace 'via' with en dash in tweet-this box on blog posts

Mike Lewisrequested to merge
update-tweet-link-on-posts into master

The current Twitter box in our blog posts has a message like this:

GitLab 11.1 released with Security Dashboards and enhanced code search via @andreasmarc

"Via" makes it seem like the item mentioned (e.g. enhanced code search) was authored by that user, not that they were the blog post author. Or at the very least, it's ambiguous.

So I changed this to an en dash instead of "via", so it would become:

GitLab 11.1 released with Security Dashboards and enhanced code search – @andreasmarc

(In the tweet itself, the URL of the page would follow in each case, as always.)

Also, this share link was not working in the Android twitter app due to a duplicate (incorrect) use of the phrase amp; in the code. (The title and author would show up in the draft tweet, but not the URL.) I've already fixed that here.

Edited by Mike Lewis

Merge request reports