Skip to content

Removes abort short circuits in release post kickoff

Chase Southard requested to merge release_kickoff_remove_dir_short_circuit into master

Why is this change being made?

💡 Provide a detailed answer to the question on why this change is being proposed, in accordance with our value of Transparency.

During the kickoff for the 16.6 Release Post, we discovered that the automated tasks had failed. (See commentary in #34731 (comment 1633676832)). The failure was not a bug per se, but a self-imposed trap to stop the script from proceeding if certain directories already existed. In this case, source/images/16_6 already existed containing the cover image, 16_6-cover-image.png.

The method in which the directory is created should not be destructive with the current options. Therefore, we don't need to have the defensive statement that aborts the script if the directory already exists.

This MR removes a pair of unnecessary abort statements meant to protect mkdir.

Author and Reviewer Checklist

Please verify the check list and ensure to tick them off before the MR is merged.

  • Provided a concise title for this Merge Request (MR)
  • Added a description to this MR explaining the reasons for the proposed change, per say why, not just what
    • Copy/paste the Slack conversation to document it for later, or upload screenshots. Verify that no confidential data is added, and the content is SAFE
  • Assign reviewers for this MR to the correct Directly Responsible Individual/s (DRI)
    • If the DRI for the page/s being updated isn’t immediately clear, then assign it to one of the people listed in the Maintained by section on the page being edited
    • If your manager does not have merge rights, please ask someone to merge it AFTER it has been approved by your manager in #mr-buddies
    • The when to get approval handbook section explains the workflow in more detail
  • For transparency, share this MR with the audience that will be impacted.
    • Team: For changes that affect your direct team, share in your group Slack channel
    • Department: If the update affects your department, share the MR in your department Slack channel
    • Company: If the update affects all (or the majority of) GitLab team members, post an update in #whats-happening-at-gitlab linking to this MR
Edited by Chase Southard

Merge request reports