Skip to content

Remove the division directory for team member YAML files

Lin Jen-Shin requested to merge move-team-member-without-division-directory into master

Why is this change being made?

This is essentially undoing !128325 (merged)

The intention to use division as the directory at the beginning was making it easier for managers to find their team members. However, we realized this extra directory increases quite some complexity for data synchronization from Workday automation, especially when the team members are moving between the divisions, we have to maintain that the directory is correct, which is further complexity and more rooms for errors.

We decided to go back and remove this extra directory.

See the discussions around #34435 (comment 1533960534)

Sorry about the back and forth and the potential conflicts and data loss caused by this giant merge request moving so many people 🙏

How to search for all people under Engineering, Product, or Security?

Since we added a new division field for team members for these divisions, we can search for division: engineering or division: product to regain how we can look over all files under a specific division.

Note that this only works for the following divisions:

  • division: engineering
  • division: product
  • division: security

Another note that we'll synchronize division with Workday data from https://gitlab.com/gitlab-com/people-group/peopleops-eng/employment-automation/-/merge_requests/660 and after that it'll be expanded to all divisions. Also given the data from Workday is capitalized, we'll need to search as such if one is searching with case-sensitivity:

  • division: Engineering
  • division: Product
  • division: Security

Background

This is done by running:

scripts/move-team-member-without-division.rb

Author and Reviewer Checklist

Please verify the check list and ensure to tick them off before the MR is merged.

  • Provided a concise title for this Merge Request (MR)
  • Added a description to this MR explaining the reasons for the proposed change, per say why, not just what
    • Copy/paste the Slack conversation to document it for later, or upload screenshots. Verify that no confidential data is added, and the content is SAFE
  • Assign reviewers for this MR to the correct Directly Responsible Individual/s (DRI)
    • If the DRI for the page/s being updated isn’t immediately clear, then assign it to one of the people listed in the Maintained by section on the page being edited
    • If your manager does not have merge rights, please ask someone to merge it AFTER it has been approved by your manager in #mr-buddies
    • The when to get approval handbook section explains the workflow in more detail
  • For transparency, share this MR with the audience that will be impacted.
    • Team: For changes that affect your direct team, share in your group Slack channel
    • Department: If the update affects your department, share the MR in your department Slack channel
    • Company: If the update affects all (or the majority of) GitLab team members, post an update in #whats-happening-at-gitlab linking to this MR
Edited by Lin Jen-Shin

Merge request reports