Skip to content

Hossein Pursultani - CNG - maintainer

Peter Lu requested to merge master-patch-2a4e into master

Manager Justification

It's hard to specify hard requirements for becoming a maintainer, which is why the documentation consists of flexible guidelines. Reviewers are encouraged to think of their eligibility for maintainership in the terms of "I could be ready at any time to be a maintainer as long as it is justified".

  • The MRs reviewed by the candidate consistently make it through maintainer review without significant additionally required changes.
  • The MRs authored by the candidate consistently make it through reviewer and maintainer review without significant required changes.

@pursultani has been working on the CNG project for years, he is also working on a complex refactoring MR currently.

Also more details in his previous trainee issue - Trainee BE maintainer (CNG) - Hossein Pursultani (#11843 - closed)

Before Merging (Manager Tasks)

  • Close any relevant trainee maintainer issues with a comment indicating that this merge request is being created, as (they are no longer required to become a maintainer).
  • Update _maintainer project_ to the correct project in @gitlab-org/maintainers group below
  • Mention the maintainers from the given specialty with the template below.
  • Leave this merge request open for 1 week, to give the maintainers time to provide feedback.
  • Ensure we have at least 2 approvals from existing maintainers.
Template call to action 
SPECIALITY Maintainers, please review this proposal to make TRAINEE maintainer of PROJECT. 

* If you have blocking feedback adhering [to the documentation](https://about.gitlab.com/handbook/engineering/workflow/code-review/#how-to-become-a-project-maintainer) please share it with me via Slack.
* If you are in agreement please approve the MR

After 1 week, if there is no blocking feedback and at least 2 approvals, I will merge this MR.

Once This MR is Merged

  1. Ask a maintainer to add you to @gitlab-org/maintainers/cloud-native-images with Owner access level
  2. Join the #distribution_maintainers Slack channel
  3. Ask the maintainers in your group to invite you to any maintainer-specific meeting if one exists
  4. Announce it everywhere
  5. Familiarize yourself with documentation for Merging a merge request
  6. Keep reviewing, start merging 🤘 😎 🤘
Edited by Jason Plum

Merge request reports