Skip to content

Moves downcase to the key variable

Chase Southard requested to merge correct_logic_for_suggested_key into master

Why is this change being made?

During the 16.3 release post preparations, we found that the release post item validator would break when a capitalized stage name was supplied. The method that suggests the lowercased version contained a no method / type error.

On line 124, we are moving .downcase.tr(' ', '_') method chain to the key variable and not the include method which returns a boolean type not string. The corrected version is stage_keys.include?(key.downcase.tr(' ', '_') || '')

Author and Reviewer Checklist

Please verify the check list and ensure to tick them off before the MR is merged.

  • Provided a concise title for this Merge Request (MR)
  • Added a description to this MR explaining the reasons for the proposed change, per say why, not just what
    • Copy/paste the Slack conversation to document it for later, or upload screenshots. Verify that no confidential data is added, and the content is SAFE
  • Assign reviewers for this MR to the correct Directly Responsible Individual/s (DRI)
    • If the DRI for the page/s being updated isn’t immediately clear, then assign it to one of the people listed in the Maintained by section on the page being edited
    • If your manager does not have merge rights, please ask someone to merge it AFTER it has been approved by your manager in #mr-buddies
    • The when to get approval handbook section explains the workflow in more detail
  • For transparency, share this MR with the audience that will be impacted.
    • Team: For changes that affect your direct team, share in your group Slack channel
    • Department: If the update affects your department, share the MR in your department Slack channel
    • Company: If the update affects all (or the majority of) GitLab team members, post an update in #whats-happening-at-gitlab linking to this MR
Edited by Chase Southard

Merge request reports