Skip to content

Add Ankit Panchal as frontend maintainer

Ankit Panchal requested to merge ankit.panchal-add-fe-maintainer into master

Manager Justification

It's hard to specify hard requirements for becoming a maintainer, which is why the documentation consists of flexible guidelines. Reviewers are encouraged to think of their eligibility for maintainership in the terms of "I could be ready at any time to be a maintainer as long as it is justified".

  • The MRs reviewed by the candidate consistently make it through maintainer review without significant additionally required changes.
  • The MRs authored by the candidate consistently make it through reviewer and maintainer review without significant required changes.

...justification...

MRs reviewed

Has reviewed nearly 120 MRs

Few recent reviews:

Some more feedback from the trainee maintainer issue when it was relevant.

Links to Non-Trivial MRs I've Written

MR Changes Notes
Moving Observability UI (ex Opstrace)'s Navigat... (gitlab-org/gitlab!103161 - merged) +479-97 This MR was complex as Observability platform was being iframed inside gitlab and navigation should work from gitlab. I have used postMessage communication between observability UI and Gitlab. I had to update CSP policy accordingly.
Update Snowplow version from 2.17.3 to 3.8.0 fo... (gitlab-org/gitlab!115573 - merged), https://gitlab.com/groups/gitlab-org/-/epics/117513+ >+265-441 I updated snowplow's version 2.17.3 to 3.8.0 , Main challenge was snowplow has changed some of the methods and moved to plugins architecture, So I had to verify which plugins we need and test it throughly. I also transitioned Snowplow from a hardcoded sp.js file to an npm package, simplifying the process of updating its version.
Adding Skeleton loader into Observability UI if... (gitlab-org/gitlab!104818 - merged) >+447<-36 For an enhanced user experience, I integrated a skeleton display based on the observability UI page accessible from the navigation. While a fast network doesn't necessitate the skeleton, it's essential to display it on slower networks to avoid presenting a blank screen.
Add Gitlab Internal Events to Frontend to unify... (gitlab-org/gitlab!123901 - merged) / Add API endpoint for Internal Events Tracking (gitlab-org/gitlab!124561 - merged) / Add raw Javascript tracking for Gitlab Internal... (gitlab-org/gitlab!125016 - merged) / Add data-track attribute for Gitlab Internal Ev... (gitlab-org/gitlab!125969 - merged) >+300-41 This was big learning opportunity for me as I have worked on unified tracking system for redisHLL and snowplow, worked on creating Backend API and consuming those in the frontend. related docs

Before Merging (Manager Tasks)

  • Close any relevant trainee maintainer issues with a comment indicating that this merge request is being created, as (they are no longer required to become a maintainer).
  • Mention the maintainers from the given specialty and ask them to provide feedback to the manager directly.
  • Leave this merge request open for 1 week, to give the maintainers time to provide feedback.
  • Ensure we have at least 2 approvals from existing maintainers.

Once This MR is Merged

  1. Create an access request for maintainer access to gitlab-org/<project>.
  2. Join the [at]frontend-maintainers slack group
  3. Ask the maintainers in your group to invite you to any maintainer-specific meeting if one exists.
  4. Let a maintainer add you to gitlab-org/maintainers/frontend with Owner access level.
  5. Announce it everywhere
  6. Keep reviewing, start merging 🤘 😎 🤘
Edited by Vitaly Slobodin

Merge request reports