Skip to content

Designate Dheeraj Joshi as a Frontend maintainer for GitLab

Amar Patel requested to merge djadmin-frontend-maintainer into master

Manager Justification

It's hard to specify hard requirements for becoming a maintainer, which is why the documentation consists of flexible guidelines. Reviewers are encouraged to think of their eligibility for maintainership in the terms of "I could be ready at any time to be a maintainer as long as it is justified".

  • The MRs reviewed by the candidate consistently make it through maintainer review without significant additionally required changes.

  • The MRs authored by the candidate consistently make it through reviewer and maintainer review without significant required changes.

  • Dheeraj(@djadmin) is a Senior Frontend Engineer and has been working with the Secure section for more than 3.5 years across multiple categories (SAST, DAST, and Frontend Security)

  • Dheeraj has approved more than 350 merge requests inside the GitLab project.

  • Dheeraj has authored more than 290 merge requests inside the GitLab project.

  • Dheeraj has authored more than 50 merge requests in the GitLab Security mirror.

He has been a keen reviewer when it comes to security-related MRs and has raised security concerns on multiple occasions. He also reviews the DOMPurify dependency upgrades.

He is also a reviewer for the gitlab-vscode-extension project.

Related Links (for reference only)

  1. Trainee FE maintainer (GitLab) Issue: #13612 (closed)

  2. Trainee maintainer mentorship with @ekigbo

  3. Process to become a maintainer: https://about.gitlab.com/handbook/engineering/workflow/code-review/#how-to-become-a-project-maintainer

Before Merging (Manager Tasks)

  • Close any relevant trainee maintainer issues with a comment indicating that this merge request is being created, as (they are no longer required to become a maintainer).
  • Mention the maintainers from the given specialty and ask them to provide feedback to the manager directly.
  • Leave this merge request open for 1 week, to give the maintainers time to provide feedback.
  • Ensure we have at least 2 approvals from existing maintainers.

Once This MR is Merged

  1. Create an access request for maintainer access to gitlab-org/<project>.
  2. Join the [at]frontend-maintainers slack group
  3. Ask the maintainers in your group to invite you to any maintainer-specific meeting if one exists.
  4. Let a maintainer add you to gitlab-org/maintainers/frontend
  5. Announce it everywhere
  6. Keep reviewing, start merging 🤘 😎 🤘
Edited by Dheeraj Joshi

Merge request reports