Draft: Update scripts/deploy to get GCP credentials from Vault instead of using service account keys
Why is this change being made?
Service account keys need to be rotated regularly which is manual work that could be avoided entirely, and are also a security risk if they ever get leaked. Using service account impersonation via Vault instead gives us a temporary access token (1 hour TTL by default), which is safer and doesn't require any manual credential rotation.
Part of #34143 and https://gitlab.com/gitlab-com/gl-infra/reliability/-/issues/16689
Author Checklist
-
Provided a concise title for this Merge Request (MR) -
Added a description to this MR explaining the reasons for the proposed change, per say why, not just what - Copy/paste the Slack conversation to document it for later, or upload screenshots. Verify that no confidential data is added, and the content is SAFE
-
Assign reviewers for this MR to the correct Directly Responsible Individual/s (DRI) - If the DRI for the page/s being updated isn’t immediately clear, then assign it to one of the people listed in the
Maintained by
section on the page being edited - If your manager does not have merge rights, please ask someone to merge it AFTER it has been approved by your manager in #mr-buddies
- The when to get approval handbook section explains the workflow in more detail
- If the DRI for the page/s being updated isn’t immediately clear, then assign it to one of the people listed in the
-
If the changes affect team members, or warrant an announcement in another way, please consider posting an update in #whats-happening-at-gitlab linking to this MR - If this is a change that directly impacts the majority of global team members, it should be a candidate for #company-fyi. Please work with internal communications and check the handbook for examples.
Edited by Pierre Guinoiseau