Skip to content

Make Mikołaj Wawrzyniak a be maintainer of version app

Mikołaj Wawrzyniak requested to merge mwaw/make_mikolaj_wawrzyniak_backend_maintaienr_of_version_app into master

Manager Justification

It's hard to specify hard requirements for becoming a maintainer, which is why the documentation consists of flexible guidelines. Reviewers are encouraged to think of their eligibility for maintainership in the terms of "I could be ready at any time to be a maintainer as long as my work as an author and reviewer is consistent with other maintainers".

  • The MRs reviewed by the candidate consistently make it through maintainer review without significant additionally required changes.
  • The MRs authored by the candidate consistently make it through reviewer and maintainer review without significant required changes.

@mikolaj_wawrzyniak has been member of Product Intelligence since September 2020, he also is backend maintainer of https://gitlab.com/gitlab-org/gitlab since November 2020. During that time:

  1. Mikołaj reviewed 8 MRs in Version App repository
  2. Mikołaj get 15 MRs merged in Version App repository
  3. Mikołaj prepared 2 release packages for JiHu team
  4. Mikołaj was leading project to move Version App to public project to adhere with transparency value https://gitlab.com/gitlab-org/gitlab/-/issues/363564
  5. Mikołaj has reviewed over 446 MRs at https://gitlab.com/gitlab-org/gitlab

Before Merging (Manager Tasks)

  • Close any relevant trainee maintainer issues with a comment indicating that this merge request is being created, as (they are no longer required to become a maintainer).
  • Mention the maintainers from the given specialty with the template below.
  • Leave this merge request open for 1 week, to give the maintainers time to provide feedback.
  • Ensure we have at least 2 approvals from existing maintainers.
Template call to action 
Backend Maintainers, please review this proposal to make Mikołaj Wawrzyniak maintainer of https://gitlab.com/gitlab-org/gitlab-services/version.gitlab.com. 

* If you have blocking feedback adhering [to the documentation](https://about.gitlab.com/handbook/engineering/workflow/code-review/#how-to-become-a-project-maintainer) please share it with me via Slack.
* If you are in agreement please approve or give a 👍 on the MR

After 1 week, if there is no blocking feedback and at least 2 approvals, I will merge this MR.

Once This MR is Merged

  1. Join the #backend_maintainers Slack channel
  2. Ask the maintainers in your group to invite you to any maintainer-specific meeting if one exists.
  3. Let a maintainer add you to @gitlab-org/maintainers/rails-backend
  4. Announce it everywhere
  5. Keep reviewing, start merging 🤘 😎 🤘
Edited by Mikołaj Wawrzyniak

Merge request reports