Skip to content

Update nbelokolodov as backend maintainer

Niko Belokolodov requested to merge nbelokolodov-master-patch-79421 into master

Overview

I've worked at GitLab as a backend engineer in product intelligence since October 2021.

My backend maintainer issue #13663 (closed) with review examples

Self-assessed areas to improve

  • Make my reviews more collaborative by asking questions instead of trying to figure out things myself.
  • Dive deeper in other parts of the app.

Self-assessed strengths

  • Not afraid of asking naive questions or asking for help.
  • Positive reviews.
  • Domain expertise in product intelligence domain as well as good knowledge of Auth/Authorisation and Web API.

@tkuah @stanhu @dstull @kassio @dbalexandre @engwan please chime in below with your thoughts, and approve this MR if you agree 🙏

Manager Justification

It's hard to specify hard requirements for becoming a maintainer, which is why the documentation consists of flexible guidelines. Reviewers are encouraged to think of their eligibility for maintainership in the terms of "I could be ready at any time to be a maintainer as long as my work as an author and reviewer is consistent with other maintainers".

  • The MRs reviewed by the candidate consistently make it through maintainer review without significant additionally required changes.
  • The MRs authored by the candidate consistently make it through reviewer and maintainer review without significant required changes.

Before Merging (Manager Tasks)

  • Mention the maintainers from the given specialty and ask them to provide feedback to the manager directly.
  • Leave this merge request open for 1 week, to give the maintainers time to provide feedback.
  • Ensure we have at least 2 approvals from existing maintainers.

Once This MR is Merged

  1. Create an access request for maintainer access to gitlab-org/<project>.
  2. Join the #backend_maintainers Slack channel
  3. Ask the maintainers in your group to invite you to any maintainer-specific meeting if one exists.
  4. Let a maintainer add you to @gitlab-org/maintainers/rails-backend
  5. Announce it everywhere
  6. Keep reviewing, start merging 🤘 😎 🤘
Edited by Sebastian Rehm

Merge request reports