Skip to content

Fix misleading typo in image caption

Michał Krawczyk requested to merge (removed):master into master

Why is this change being made?

I believe the caption for the 2021 is not accurate and should say one queue per worker rather than one queue per shard, which is actually what the next image in the blog post is depicting if my understanding is correct.

I'm reading through all the different sources/issues/mrs of the incredible work GitLab has done in changing the sidekiq architecture and this particular caption was pretty much confusing me (as my understanding is the 'shards' on the image are urgent cpu-bound, catchall etc. and they actually have multiple queues assigned), until the point when I've checked what the referenced .png file is named to confirm (I hope) my suspicion.

Author Checklist

  • Provided a concise title for this Merge Request (MR)
  • Added a description to this MR explaining the reasons for the proposed change, per say why, not just what
    • Copy/paste the Slack conversation to document it for later, or upload screenshots. Verify that no confidential data is added.
  • Assign reviewers for this MR to the correct Directly Responsible Individual/s (DRI)
    • If the DRI for the page/s being updated isn’t immediately clear, then assign it to one of the people listed in the Maintained by section on the page being edited
    • If your manager does not have merge rights, please ask someone to merge it AFTER it has been approved by your manager in #mr-buddies
  • If the changes affect team members, or warrant an announcement in another way, please consider posting an update in #whats-happening-at-gitlab linking to this MR
    • If this is a change that directly impacts the majority of global team members, it should be a candidate for #company-fyi. Please work with internal communications and check the handbook for examples.

Edited by Michał Krawczyk

Merge request reports

Loading