Set himkp as maintainer for gitlab
Manager Justification
It's hard to specify hard requirements for becoming a maintainer, which is why the documentation consists of flexible guidelines. Reviewers are encouraged to think of their eligibility for maintainership in the terms of "I could be ready at any time to be a maintainer as long as it is justified".
-
The MRs reviewed by the candidate consistently make it through maintainer review without significant additionally required changes. -
The MRs authored by the candidate consistently make it through reviewer and maintainer review without significant required changes.
- Himanshu(@himkp) is a Senior Frontend Engineer and has been working with the Editor team for more than 3 years across multiple categories(Web IDE, Content Editor, Wiki, Snippets etc)
- Himanshu has approved more than 460 merge requests inside the GitLab project.
- Himanshu has authored more than 230 merge requests inside the GitLab project.
Total MRs I reviewed in the last 3 months (GitLab): | 25 |
---|---|
MRs were merged as is: | 23 (92%) |
MRs were merged after implementing small suggestions from the maintainer | 2 (8%) |
MRs needed a larger input from the maintainer | 0 (0%) |
Some of my features were selected as top feature for GitLab releases:
- Adding support for autocomplete suggestions in content editor.
- Add support for autocomplete suggestions in con... (gitlab-org/gitlab!90753 - merged)
- Add support for emojis suggestions in content e... (gitlab-org/gitlab!99471 - merged)
- Add support for quick actions in content editor (gitlab-org/gitlab!100688 - merged)
- Wrap up support for autocomplete suggestions in... (gitlab-org/gitlab!100791 - merged)
- Selected as top (headline) feature for 15.5.
- Support for live previewing and editing PlantUML, Kroki and Mermaid diagrams in content editor in collaboration with Michael and Enrique.
- Multiple contributions which were chosen as the top feature for the release post for 15.0.
- Inserting table of contents in content editor with live updates.
Example of non-trivial MRs that I reviewed:
- Add auto-scrolling to dropdown vue component du... (gitlab-org/gitlab!101578 - merged)
- Client-side Commonmark to ProseMirror deserializer (gitlab-org/gitlab!85716 - merged)
- Content Editor: Handle block and inline nodes w... (gitlab-org/gitlab!91628 - merged)
Before Merging (Manager Tasks)
-
Mention the maintainers from the given specialty and ask them to provide feedback to the manager directly. -
Leave this merge request open for 1 week, to give the maintainers time to provide feedback. -
Ensure we have at least 2 approvals from existing maintainers.
Once This MR is Merged
-
Create an access request for maintainer access to gitlab-org/gitlab
. -
Join the [at]frontend-maintainers
slack group -
Ask the maintainers in your group to invite you to any maintainer-specific meeting if one exists. -
Let a maintainer add you to gitlab-org/maintainers/frontend
-
Announce it everywhere -
Keep reviewing, start merging 🤘 😎 🤘
Edited by Himanshu Kapoor