Skip to content

Make Bogdan Denkovych a GitLab backend maintainer

Michelle Gill requested to merge m_gill-master-patch-29040 into master

Manager Justification

It's hard to specify hard requirements for becoming a maintainer, which is why the documentation consists of flexible guidelines. Reviewers are encouraged to think of their eligibility for maintainership in the terms of "I could be ready at any time to be a maintainer as long as my work as an author and reviewer is consistent with other maintainers".

  • The MRs reviewed by the candidate consistently make it through maintainer review without significant additionally required changes.
  • The MRs authored by the candidate consistently make it through reviewer and maintainer review without significant required changes.
  1. @bdenkovych has been part of the Auth team as an engineer for just over 1 year, and was a community contributor for about 6 years prior to that. He is well aware of the GitLab standards, workflows, and support of the community by this time.
  2. In his time on the team, he has authored 33 merge requests with some being quite complex and involving multiple reviews - such as the Microsoft Graph API work. This work required him to solve the problem, create a gem which will be open-sourced, work with distribution to have it included in omnibus and helm charts, and ultimately collaborate across many functional groups.
  3. He has approved 58 merge requests (29 of those were outside of his area) and he has been required as part of the Auth code review process to give approval on additional merge requests if they touch his groups area. This additional code review requires scrutinizing quality and also understanding moving pieces of the product to make sure changes do not have unintended side effects, similar to a "maintainer+" review.
  4. @bdenkovych is also a contributor to the Ruby project and has been contributing to the Rails project since March 2016 (376 "pull requests" here)
  5. @bdenkovych has a history of thorough/complex reviews which I have listed examples of below, many of them have dozens of comments:

@bdenkovych may not have 100+ reviews and MRs to showcase his talent at GitLab specifically, but has plenty of data to support that he is experienced and knowledgable about our product and standards to become a maintainer of the gitlab-org/gitlab project.

Before Merging(Manager Tasks)

  • Mention the maintainers from the given specialty and ask them to provide feedback directly on this merge request.
  • Leave this merge request open for 1 week, to give the maintainers time to provide feedback.
  • Ensure we have at least 2 approvals from existing maintainers.

Once This MR is Merged

  1. Create an access request for maintainer access to gitlab-org/<project>.
  2. Join the backend-maintainers slack group
  3. Ask the maintainers in your group to invite you to any maintainer-specific meeting if one exists.
  4. Let a maintainer add you to @gitlab-org/maintainers/rails-backend
  5. Announce it everywhere
  6. Keep reviewing, start merging 🤘 😎 🤘
Edited by Bogdan Denkovych

Merge request reports