Skip to content

Make Drew Blessing GitLab backend maintainer

Drew Blessing requested to merge dblessing_backend_maintainer into master

Manager Justification

It's hard to specify hard requirements for becoming a maintainer, which is why the documentation consists of flexible guidelines. Reviewers are encouraged to think of their eligibility for maintainership in the terms of "I could be ready at any time to be a maintainer as long as my work as an author and reviewer is consistent with other maintainers".

  • The MRs reviewed by the candidate consistently make it through maintainer review without significant additionally required changes.
  • The MRs authored by the candidate consistently make it through reviewer and maintainer review without significant required changes.
  1. Drew has just recently celebrated his 7 year anniversary at GitLab (different roles) and has been part of the Auth team as an engineer for about 2.5 years. He is well aware of the GitLab standards, workflows, and support of the community by this time.
  2. In his time on the team, he has authored 213 merged merge requests out of a total 249. He is a domain expert by this time in several areas, delivering huge features like Domain Verification and Group SAML with little to no regressions.
  3. He has approved 289 merge requests (181 of those were outside of his area) and for the last year he has been required as part of the Auth code review process to give approval on additional merge requests if they touch his groups area. This additional code review requires scrutinizing quality and also understanding moving pieces of the product to make sure changes do not have unintended side effects, similar to a "maintainer+" review.

Based on the reasons listed above, Drew has the experience, understanding of the product, and regard for quality to become a maintainer of the gitlab-org/gitlab project.

Before Merging(Manager Tasks)

  • Mention the maintainers from the given specialty and ask them to provide feedback directly on this merge request.
  • Leave this merge request open for 1 week, to give the maintainers time to provide feedback.
  • Ensure we have at least 2 approvals from existing maintainers.

Once This MR is Merged

  1. Create an access request for maintainer access to gitlab-org/<project>.
  2. Join the backend-maintainers slack group
  3. Ask the maintainers in your group to invite you to any maintainer-specific meeting if one exists.
  4. Let a maintainer add you to @gitlab-org/maintainers/rails-backend
  5. Announce it everywhere
  6. Keep reviewing, start merging 🤘 😎 🤘
Edited by Drew Blessing

Merge request reports