Skip to content

Make pshutsin database maintainer of GitLab

Pavel Shutsin requested to merge pshutsin-database-maintainer-approval into master

Manager Justification

It's hard to specify hard requirements for becoming a maintainer, which is why the documentation consists of flexible guidelines. Reviewers are encouraged to think of their eligibility for maintainership in the terms of "I could be ready at any time to be a maintainer as long as it is justified".

  • The MRs reviewed by the candidate consistently make it through maintainer review without significant additionally required changes.

  • The MRs authored by the candidate consistently make it through reviewer and maintainer review without significant required changes.

  • Pavel has been a Database reviewer since April 2022 and became a trainee database maintainer in August 2022.

  • Pavel contributes to database review tools and has shared ideas for our migration framework.

  • He has received positive feedback for his database contributions / reviews both in the #thanks Slack channel as well as via team members reaching out to his manager.

Review examples

Before Merging (Manager Tasks)

  • Mention the maintainers from the given specialty and ask them to provide feedback to the manager directly.
  • Leave this merge request open for 1 week, to give the maintainers time to provide feedback.
  • Ensure we have at least 2 approvals from existing maintainers.

Once This MR is Merged

  1. Ask a maintainer to add you to @gitlab-org/maintainers/database
  2. Join the database_maintainers slack group
  3. Ask the maintainers in your group to invite you to any maintainer-specific meeting if one exists.
  4. Announce it everywhere
  5. Keep reviewing, start merging 🤘 😎 🤘
Edited by Brandon Labuschagne

Merge request reports