Skip to content

Change bug bounty council voting

Nick Malcolm requested to merge nmalcolm-master-patch-68335 into master

Why is this change being made?

The Bug Bounty Council process ensures our bounty payments and CVSS ratings are both accurate and peer reviewed. Currently three people must agree (the triager, plus two team members).

In the spirit of efficiency, and to avoid having to ask in #sec-appsec all the time, this MR makes it so Low & Medium CVSS can be approved with a single 👍. High and Critical require two which is no change current state, and helps make this change safer and more straight forward. At a later date (or now) we might decide that High and/or Critical also only need one vote.

This MR also completely removes the need for a bug emoji, since we have tightly coupled award to CVSS (and a handful of non-CVSS scenarios) with our standardised calculator.

👍 was selected over 🐛 since it's more discoverable for new team members / more likely to be in the "commonly used" section of an emoji popup.

@gitlab-com/gl-security/appsec discussion and iteration welcome!

Author Checklist

  • Provided a concise title for this Merge Request (MR)
  • Added a description to this MR explaining the reasons for the proposed change, per say why, not just what
    • Copy/paste the Slack conversation to document it for later, or upload screenshots. Verify that no confidential data is added.
  • Assign reviewers for this MR to the correct Directly Responsible Individual/s (DRI)
    • If the DRI for the page/s being updated isn’t immediately clear, then assign it to one of the people listed in the Maintained by section on the page being edited
    • If your manager does not have merge rights, please ask someone to merge it AFTER it has been approved by your manager in #mr-buddies
  • If the changes affect team members, or warrant an announcement in another way, please consider posting an update in #whats-happening-at-gitlab linking to this MR
    • If this is a change that directly impacts the majority of global team members, it should be a candidate for #company-fyi. Please work with internal communications and check the handbook for examples.

Merge request reports