Add Robert Marshall as CNG maintainer

Trainee maintainer issue: #12061 (closed)

Overview

The CNG is a low-churn project at this time, compared to many others, so numbers may look low in comparison.

As of 2022-08-26, every MR approved by Robert has been merged.

As of 2022-08-26, every MR raised by Robert has been merged.

This includes several significant suites of changes, such as:

• Implementation of OpenShift labeling requirements for certification
• Factoring Ruby out of the Workhorse container image(s) which necessitated multiple iterations to reach the end goal.
  • This direct impacts Pipeline efficiency, artifact sizes, and internal / customer OpEx

Examples of reviews

CNG gitlab-shell: remove excess & Ruby (v2) (gitlab-org/build/CNG!1062 - merged): Though this needed a second touch due to complications of file systems permissions when consumed by the GitLab Helm char (all maintainers missed), the review was thorough, well thought and communicated.

Things to improve

From @WarheadsSE

Continue impact-aware consideration and evaluation. Remember to cross-link related / impactful epic work when MRs are not already linked to a related issue. Comments pointing to related impact provide insight to other reviewers, especially with regards to the scope of "blast radius" to downstream consumers of the containers. Continue bias for action in raising follow-up or related issues from items founding during reviews.

Developer checklist

• Before this MR is merged
  • Mention existing maintainers,
  • Assign this issue to your manager
• After this MR is merged
  • Request a maintainer from the #backend_maintainers Slack channel to add you as an Owner to gitlab-org/maintainers/rails-backend
  • Consider adding 'backend maintainer' to your Slack notification keywords

Manager checklist

• Before this MR is merged
  • The MR has been open for 5 working days
  • If we have 10 or fewer maintainers, more than half of the existing maintainers approve the MR, otherwise if we have 11 or more maintainers, 5 existing maintainers approve the MR
  • There are no blocking concerns raised (if there are, please follow https://about.gitlab.com/handbook/engineering/workflow/code-review/#how-to-become-a-project-maintainer)
• After this MR is merged
  • Announce the good news in the relevant channels listed in https://about.gitlab.com/handbook/engineering/#keeping-yourself-informed