Apply for Maintainership to GitLab project for Allen Cook
Trainee maintainer issue: #13239 (closed)
Overview
I've been at GitLab about a year and I've reviewed and approved 149 MRs in my time at GitLab. I want to take on more responsibility for the codebase for my team to help deliver on our goals.
Examples of reviews
- #13239 (comment 933408835) - Suggested a simplification to the code structure to avoid duplicate code
- #13239 (comment 935101685) - Several questions about the specs led to improvements
- #13239 (comment 960233532) - Requested query plans to demonstrate performance improvements
- #13239 (comment 1012208062) - Suggested improvements to the JSON endpoint and specs to adhere to GitLab standards
- #13239 (comment 1012230502) - Discussed improved specs and detailed process for adding database constraints
- #13239 (comment 1028023430) - Suggested to break larger MR into several smaller steps to allow for refactoring with less disruption
Things to improve
- I need to become more familiar with different areas of the codebase
- I need to find experts in areas and ping them when a review is out of my field
@gitlab-org/maintainers/rails-backend please chime in below with your thoughts, and approve this MR if you agree.
Developer checklist
-
Before this MR is merged -
Mention @gitlab-org/maintainers/rails-backend
, if not done (this issue template should do this automatically) -
Assign this issue to your manager
-
-
After this MR is merged -
Request a maintainer from the #backend_maintainers
Slack channel to add you as an Owner togitlab-org/maintainers/rails-backend
-
Consider adding 'backend maintainer' to your Slack notification keywords
-
Manager checklist
-
Before this MR is merged -
The MR has been open for 5 working days -
If we have 10 or fewer backend maintainers, more than half of the existing maintainers approve the MR, otherwise if we have 11 or more maintainers, 5 existing maintainers approve the MR (see the maintainer list) -
There are no blocking concerns raised (if there are, please follow https://about.gitlab.com/handbook/engineering/workflow/code-review/#how-to-become-a-project-maintainer)
-
-
After this MR is merged -
Announce the good news in the relevant channels listed in https://about.gitlab.com/handbook/engineering/#keeping-yourself-informed
-
Edited by Allen Cook