Add George Koltsov as backend maintainer - GitLab
Trainee maintainer issue: #12000 (closed)
Overview
- Started at GitLab July 3rd, 2019
268 MRs merged
-
222 MRs reviewed
since the creation of trainee maintainer issue -
417
MR reviews/approvals overall since I started
Examples of reviews
-
Removes unnecessary tabs from DAST view scans
- Post review notes - siplification of the proposed approach -
GithubImport: Enable users to import _modern_ diff notes
- Post review notes - catching edge cases for the imported diffs -
Dependency Proxy uses workhorse for manifest pulls
- Post review notes - complex review example -
Use allowlist of allowed attributes for imported models
- Post review notes - reducing duplication & identifying potential regression scenario -
Require email verification
- understanding the requirements, involving domain experts to make sure vision is aligned
Things to improve
@gitlab-org/maintainers/rails-backend please chime in below with your thoughts, and approve this MR if you agree.
Developer checklist
-
Before this MR is merged -
Mention @gitlab-org/maintainers/rails-backend
, if not done (this issue template should do this automatically) -
Assign this issue to your manager
-
-
After this MR is merged -
Request a maintainer from the #backend_maintainers
Slack channel to add you as an Owner togitlab-org/maintainers/rails-backend
-
Consider adding 'backend maintainer' to your Slack notification keywords
-
Manager checklist
-
Before this MR is merged -
The MR has been open for 5 working days -
If we have 10 or fewer backend maintainers, more than half of the existing maintainers approve the MR, otherwise if we have 11 or more maintainers, 5 existing maintainers approve the MR (see the maintainer list) -
There are no blocking concerns raised (if there are, please follow https://about.gitlab.com/handbook/engineering/workflow/code-review/#how-to-become-a-project-maintainer)
-
-
After this MR is merged -
Announce the good news in the relevant channels listed in https://about.gitlab.com/handbook/engineering/#keeping-yourself-informed
-
Edited by George Koltsov