Skip to content

Create more consistency in quoting pattern in pets.yml.

Adam Jensen requested to merge aj-pets-quote-issues-jun22 into master

Why is this change being made?

I recently added my pets to the pets page (see !106449 (merged), !106444 (merged), !106447), copying and pasting the format from earlier entries. In the process, I ended up copying a trailing single quote into my "story" entry without putting its corresponding leading quote at the beginning, creating the problems I resolved in !106616 (merged). Several other team members seem to have made the same mistake, so I thought it might be worth adjusting the formatting of the kinds of entries that could lead to it happening again; that's what this merge request is intended to fix.

The merge request itself is unfortunately quite large in terms of lines of code changed, but each change is extremely similar. I don't know yet what all is tested in the pipeline, but I'd want to verify:

  • Is the YAML valid?
  • Does the pipeline succeed?
  • Are there any glaring rendering errors that show up in a review of the pets page as rendered with this data?

Author Checklist

  • Provided a concise title for this Merge Request (MR)
  • Added a description to this MR explaining the reasons for the proposed change, per say why, not just what
    • Copy/paste the Slack conversation to document it for later, or upload screenshots. Verify that no confidential data is added.
  • Assign reviewers for this MR to the correct Directly Responsible Individual/s (DRI)
    • If the DRI for the page/s being updated isn’t immediately clear, then assign it to one of the people listed in the Maintained by section on the page being edited
    • If your manager does not have merge rights, please ask someone to merge it AFTER it has been approved by your manager in #mr-buddies
  • If the changes affect team members, or warrant an announcement in another way, please consider posting an update in #whats-happening-at-gitlab linking to this MR
    • If this is a change that directly impacts the majority of global team members, it should be a candidate for #company-fyi. Please work with internal communications and check the handbook for examples.

Edited by Adam Jensen

Merge request reports