Skip to content

Adds Josianne Hyson as a maintainer for CustomersDot

Josianne Hyson requested to merge jhyson-master-patch-89504 into master

Trainee maintainer issue: https://gitlab.com/gitlab-com/www-gitlab-com/-/issues/12962

Overview

I joined the Fulfilment purchase team in October 2020 as part of the EoA headcount reset. Since then I have authored 66 merge requests (and reviewed 126).

I have reviewed 29 MRs within my trainee maintainer issue, 18 of which were merged as-is.

Examples of reviews

Things to improve

I tended to miss things the most when I was unfamiliar with a particular area. This shows me that I should make an effort to ask more clarifying questions and not be afraid to ask for more input from domain experts.

One of the main things I missed during the trainee maintainership was not properly following the testing instructions for this MR https://gitlab.com/gitlab-com/www-gitlab-com/-/issues/12962#note_959016301 and missing that it didn't actually resolve the issue. Since that MR I have been more careful to read the instructions and test the changes described properly. This is something I'll need to be much more careful of as a maintainer as there is no reviewer afterwards to catch things!

@cwiesner @shreyasagarwal @tyleramos @vij @vshumilo please chime in below with your thoughts, and approve this MR if you agree.

Developer checklist

  • Before this MR is merged
    • Mention CustomersDot maintainers, if not done
    • Assign this issue to your manager
  • After this MR is merged
    • Request a maintainer from the #backend_maintainers Slack channel to add you as an Owner to gitlab-org/maintainers/rails-backend
    • Consider adding 'backend maintainer' to your Slack notification keywords

Manager checklist

Edited by Ragnar Hardarson

Merge request reports