Add acroitor as a backend maintainer
Trainee maintainer issue: #8889 (closed)
Overview
I've been at GitLab since February 2019, working in the various forms of the groupproject management and part of the Groups and Projects Consolidation initiative in ~"group::workspace" as a backend engineer.
I've been in maintainer trainee program since August 2020.
I've contributed > 300 MRs, and have reviewed & approved almost 500 MRs as a backend reviewer and Database reviewer.
Examples of reviews
Some of the most recent MRs reviewed/approved
- Add database column and setting logic for licen... (gitlab-org/gitlab!89016 - merged)
- Ensure application settings in tests adhere to ... (gitlab-org/gitlab!88687 - merged)
- Delete invalid EpicIssue records (gitlab-org/gitlab!79557 - merged)
- Add hierarchy widget to work items (gitlab-org/gitlab!88429 - merged)
- Faster ancestors linear scope query (gitlab-org/gitlab!83371 - merged)
Reviews the code on my local machine to confirm behaviour
- Add hierarchy widget to work items (gitlab-org/gitlab!88429 - merged)
- Look for existing users by email and cache in m... (gitlab-org/gitlab!82196 - merged)
- Add deprecation alert for manual cadences (gitlab-org/gitlab!82458 - merged)
Contribute with patches as part of the review
- Add GraphQL query to fetch single epic board list (gitlab-org/gitlab!85581 - merged)
- Add container_images to Project/Group GraphQL API (gitlab-org/gitlab!88806 - merged)
Things to improve
There are always things to improve:
- Learn more about different domains of the app (e.g. I am not so familiar with our CI/CD templating or infrastructure parts of the product)
- Be more pro-acting on asking opinions of domain experts in certain MRs
- I'm sure there is more
😄
@gitlab-org/maintainers/rails-backend please chime in below with your thoughts, and approve this MR if you agree.
Developer checklist
-
Before this MR is merged -
Mention @gitlab-org/maintainers/rails-backend
, if not done (this issue template should do this automatically) -
Assign this issue to your manager
-
-
After this MR is merged -
Request a maintainer from the #backend_maintainers
Slack channel to add you as an Owner togitlab-org/maintainers/rails-backend
-
Consider adding 'backend maintainer' to your Slack notification keywords
-
Manager checklist
-
Before this MR is merged -
The MR has been open for 5 working days -
More than half of the existing maintainers approve the MR (see the maintainer list) -
There are no blocking concerns raised (if there are, please follow https://about.gitlab.com/handbook/engineering/workflow/code-review/#how-to-become-a-project-maintainer)
-
-
After this MR is merged -
Announce the good news in the relevant channels listed in https://about.gitlab.com/handbook/engineering/#keeping-yourself-informed
-
Edited by Donald Cook