Reinstate missing Caldigit thunderbolt dock entry
Why is this change being made?
Caldigit Thunderbolt docks were removed from the expenses list in !96651 (diffs), but these have long been a required purchase for team members working with Macbook Pros. These docks (either the TS3 or the new TS4) are effectively a requirement for anyone using an external monitor/keyboard/mouse, and absolutely required for multiple displays; which are recommended and expensable. The $80 listed item for a USB-C dock is not equivalent, as a note, and only results in wasted money on expensing items that won't work. We have hundreds of engineers with these docks already and these docks are the only ones we have previously endorsed.
I don't believe the IT team were aware of this change and that MR provides no reason for why they were removed.
I've set the price to the official MSRP from Caldigit and added a description that hopefully clarifies this is largely only needed for multiple display setups.
/cc @marc_disabatino @huzaifaiftikhar1 @ahergenhan @sean_carroll
/cc @gitlab-com/Finance-Division/procurement-team
Author Checklist
-
Provided a concise title for this Merge Request (MR) -
Added a description to this MR explaining the reasons for the proposed change, per say why, not just what - Copy/paste the Slack conversation to document it for later, or upload screenshots. Verify that no confidential data is added.
-
Assign reviewers for this MR to the correct Directly Responsible Individual/s (DRI) - If the DRI for the page/s being updated isn’t immediately clear, then assign it to one of the people listed in the
Maintained by
section on the page being edited - If your manager does not have merge rights, please ask someone to merge it AFTER it has been approved by your manager in #mr-buddies
- If the DRI for the page/s being updated isn’t immediately clear, then assign it to one of the people listed in the
-
If the changes affect team members, or warrant an announcement in another way, please consider posting an update in #whats-happening-at-gitlab linking to this MR - If this is a change that directly impacts the majority of global team members, it should be a candidate for #company-fyi. Please work with internal communications and check the handbook for examples.
Merge request reports
Activity
changed milestone to %15.1
assigned to @robotmay_gitlab
Suggested Reviewers (beta)
The individuals below may be good candidates to participate in the review based on various factors.
You can use slash commands in comments to quickly assign
/assign_reviewer @user1
.Suggested Reviewers @bryanwise
,@ccnelson
,@lyle
,@dparker
,@JamesRLopes
If you do not believe these suggestions are useful, please apply the label Bad Suggested Reviewer. You can also provide feedback for this feature on this issue:
https://gitlab.com/gitlab-org/gitlab/-/issues/357923
.Automatically generated by Suggested Reviewers Bot - an experimental ML-based recommendation engine created by ~"group::applied ml".
Edited by GitLab Reviewer-Recommender Botadded Update Handbook handbook labels
Assigning to @a.hansen as the DRI for this page isn't immediately obvious, but you're listed in the maintainers for it
requested review from @a.hansen
This seems like a reasonable expense to me, but I will leave it to the Finance team to approve this change.
Edited by Sean Carroll@brobins is there a specific person this needs to be assigned to in order to progress it? You're the only other person listed on the maintainers for that page at the moment.
@brobins I do not remember seeing this dock on the expense list before. If needed for engineers, by all means we should add.
@daleb04 it was removed, hence I am trying to understand why, thanks.
added 1 commit
- 0b9ec011 - Update sites/handbook/source/handbook/finance/procurement/office-equipment-supplies/index.html.md
Hey Team!
Items get removed and added to our lists all the time. I would not strictly say this is a required accessory but a quality of life piece like most accessories.
I actually have mostly negative experiences with docking stations due to one reason or another. (lagging multi-workspaces, slow charging, etc) and prefer to use direct connect cables with my monitors and one external expansion hub. (Satechi V2)
This has been my most stable setup and it costs about 100-120 USD and I can use all my peripherals. (3 monitors, webcam, mics, external expansion)
However, I don't see a reason why this shouldn't be an allowed accessory. I just don't want to give off the impression this is a requirement for working on a Macbook Pro.
@aabbate @a.hansen tagging ya'll from procurement as I saw the original MR was crafted by procurement.
Edited by Marc Di SabatinoThanks @marc_disabatino no objections from me for listing the Caldigit docks I also agree with your points. Ultimately lets not stand in the way of allowing people to use a solution that works well for them.
@brobins @marc_disabatino @rrea1 @robotmay_gitlab @sean_carroll Apologies all - it looks like the resolution to this somehow split off into a separate request: !105397 (merged)
This was accidentally removed during a clean up activity of this page since our goal was to remove specific products. It's since been added and we did further clarify a few things based on the discussion here:
- If equipment is needed that is not listed to do ones job, please discuss with your manager and the expense slack channel. This is not meant to be a fully inclusive list.
- We generalized the dock item. Note, docks are not required. However in the instance one chooses to obtain one, we identified Caldigit as an example so the individual can choose based on their specific needs.
Thanks for bringing this to our attention and let me know if there are additional questions!
mentioned in commit b58fd58a
@brobins I guess we didn't had to merge this MR as @a.hansen already mentioned that another MR !105397 (merged) with the same changes were merged. We now have two duplicate rows.
See the first and the last row.
Let's revert this MR.
Edited by Huzaifa Iftikharmentioned in commit 827d052e
@huzaifaiftikhar1 Good catch, we will create a second MR to remove the duplicative line item: !105600 (merged)
@brobins no action needed.
Thanks all!