Adds Vijay Hawoldar as BE maintainer for CustomersDot
Trainee maintainer issue: #10834 (closed)
Overview
I joined Fulfillment in October 2020 as part of the EoA re-alignment and since then I have:
- authored 108 CustomersDot MRs
- reviewed 62 CustomersDot MRs
At the time of writing 47 reviewed MRs were merged as-is (~75%).
Examples of reviews
Things to improve
I tend to lean towards trusting all of the author's changes as completely necessary when sometimes I should question them more, or spend a little more time diving deeper into the associated code to establish the answer myself.
I think more often than not maintainer feedback on my reviews comes from having more familiarity with the topic/subject, which indicates to me that I should leverage the experience of the wider Fulfillment team by requesting insight/domain expertise when I'm unsure about a particular area or subject.
@csouthard @jameslopez @tyleramos @cwiesner @vshumilo @shreyasagarwal please chime in below with your thoughts, and approve this MR if you agree.
Developer checklist
-
Before this MR is merged -
Mention CustomersDot BE maintainers, if not done (this issue template should do this automatically) -
Assign this issue to your manager
-
-
After this MR is merged -
Request a maintainer to add you as an -
Consider adding 'backend maintainer' to your Slack notification keywords
-
Manager checklist
-
Before this MR is merged -
The MR has been open for 5 working days -
More than half of the existing maintainers approve the MR (see the maintainer list) -
There are no blocking concerns raised (if there are, please follow https://about.gitlab.com/handbook/engineering/workflow/code-review/#how-to-become-a-project-maintainer)
-
-
After this MR is merged -
Announce the good news in the relevant channels listed in https://about.gitlab.com/handbook/engineering/#keeping-yourself-informed
-