FY21 Q3 KR: Improve efficiency of enabling migration of common Pajamas components => 100%
-
Add initial Dangerbot rule to gitlab repo => 100% -
Improve the Danger rule to accommodate both blocking and non-blocking failures. (Blocking for components that has been migrated already and non-blocking for those that are not migrated yet) => 100%gitlab-org/gitlab!44256 (merged) -
Add the list of all regexes in the rule => 100%gitlab-org/gitlab!44673 (merged) -
Communicate the changes and ensure the rules are updated whenever migration happens https://gitlab.slack.com/archives/C016PM4G7FV/p1602119069008800
- Create a job that warns when deprecated instances of pagination, buttons, and alerts are introduced in a merge request
=> x% - Create a job that warns when deprecated instances of tooltips, tabs, drop-downs
=> x% - Create a job that warns when deprecated instances of modals and popovers
=> x%
Retrospective
Good
- Great Collaboration with Frontend and Engineering Productivity teams
🤝
Bad
- There was no centralised place with a list of deprecated components, but rather a collection of individual issues under the epics which made the process of collecting examples slower and less efficient.
Try
- Would be great to see continuing usage and improvement of the Danger Rule, including moving more examples to blocking in sync with the migration.
Edited by Anastasia McDonald