Refactor Team page and link_to_team_member helper to use Slug
Problem to solve
In team.yml
there is a property called slug
that appears to be inconsistently used. In most cases, it matches the team member's GitLab profile, but in some cases it is a shortened version of the team member's name or a generic job role.
The Team page seems to use the gitlab
property to build the anchor tag for linking into a specific team member. It makes more sense that we would use slug
.
There is a helper function used to generate team member links that used the slug
property and resulted in broken links. That helper was updated in this merge request (!43944 (merged)) but we should consider reverting that change and instead making the data more consistent and semantic.
Proposal
Investigate the usage of the slug
and gitlab
properties across www-gitlab-com
and refactor the data to be more consistent with the intent of the property.