Skip to content

Trainee Design Maintainer: Jeremy Elder

Basic setup

  1. Change this issue title to include your name: Trainee Design Maintainer: [Your Name].
  2. Decide which Design project you would like to become a maintainer: (design.gitlab.com).
  3. Read the design review page in the handbook.
  4. Understand how to become a maintainer and add yourself as a trainee maintainer on the team page. Use the format under projects:
    1. design.gitlab.com: trainee_maintainer UX
  5. Mention your manager in this issue for awareness.

Working towards becoming a maintainer

This is not a checklist, but guidelines that will help you become a mantainer. Remember that there is no specific timeline on this, and that you should work together with your manager and current maintainers.

All designers are maintainers of gitlab-design project. If you are interested in becoming a Maintainer of UI (.scss) for gitlab-ce, gitlab-ee, and gitlab-ui projects, please follow the Engineering Review Workflow.

It is up to you to ensure that you are getting enough MRs to review, and of varied types. You could also seek out more reviews from your team, for example by asking for reviews on the #ux and #design-system Slack channels. If you are not receiving enough MRs to advance in your training, be proactive and work on your own improvements to Pajamas. This will demonstrate overall understanding of the product, as well as quality contributions, and help propel your progress. Maintainers are available to help guide you.

Your reviews should aim to cover maintainer responsibilities as well as reviewer responsibilities. Design Maintainers should be focused on MRs that have an impact on usability, iterate on existing user experience, and/or include usage of design guidelines, standards, and patterns. Your approval means you think it is ready to merge.

After each MR is merged or closed, add a discussion to this issue using this template:

### (Merge request title): (Merge request URL)

During review:

- (List anything of note, or a quick summary. "I suggested/identified/noted...")

Post-review:

- (List anything of note, or a quick summary. "I missed..." or "Merged as-is")

(Maintainer who reviewed this merge request) Please add feedback, and compare this review to the average maintainer review.

It is your responsibility to set up any necessary meetings to discuss your progress with a current maintainer, as well as your manager. These can be at any increment that is right for you.

When you're ready to make it official

When reviews have accumulated, and recent reviews consistently fulfill maintainer responsibilities, any maintainer can take the next step. The trainee should also feel free to discuss their progress with their manager or any maintainer at any time.

  1. Create a merge request for team page proposing yourself as a maintainer for the chosen project. Use the format under projects:
    1. design.gitlab.com: maintainer UX
  2. Create a merge request for CODEOWNERS of design.gitlab.com or gitlab-svgs, adding yourself accordingly, and ask a maintainer to review it.
    1. design.gitlab.com CODEOWNERS file
    2. gitlab-svgs CODEOWNERS file
  3. Keep reviewing, start merging 😃

/cc @sarahj @clenneville @tauriedavis @pedroms

Edited by Taurie Davis