Trainee Design Maintainer (design.gitlab.com, Figma): Dan Mizzi-Harris
Basic setup
-
Decide which project and type you would like to become a maintainer of. -
Change this issue title to include your name, project, and maintainer type: Trainee Design Maintainer ([Project], [Type]): [Your Name]
. -
Read the design review page in the handbook. -
Understand how to become a maintainer and add yourself as a trainee maintainer in the team database. Indicate your selected project and maintainer type: -
design.gitlab.com: trainee_maintainer Figma
-
-
Mention a design maintainer of the project you chose and work with them to find an available Support Maintainer during the traineeship, if possible. -
Mention your manager in this issue for awareness.
Working towards becoming a maintainer
This is not a checklist, but guidelines that will help you become a maintainer. Remember that there is no specific timeline on this, and that you should work together with your manager and current maintainers.
All designers are maintainers of gitlab-design
project. If you are interested in becoming a Maintainer of UI (.scss
) for
gitlab-ce
, gitlab-ee
, and gitlab-ui
projects, please follow the Engineering Review Workflow.
It is up to you to ensure that you are getting enough MRs to review, and of varied
types. You could also seek out more reviews from your team, for example by asking
for reviews on the #ux
and #design-system
Slack channels. If you are not
receiving enough MRs to advance in your training, be proactive and work on your
own improvements to Pajamas. This will demonstrate overall understanding of the
product, as well as quality contributions, and help propel your progress.
Maintainers are available to help guide you.
Your reviews should aim to cover maintainer responsibilities as well as reviewer responsibilities. Design Maintainers should be focused on MRs that have an impact on usability, iterate on existing user experience, and/or include usage of design guidelines, standards, and patterns. Your approval means you think it is ready to merge.
After each MR is merged or closed, add a discussion to this issue using this template:
### (Merge request title): (Merge request URL)
During review:
- (List anything of note, or a quick summary. "I suggested/identified/noted...")
Post-review:
- (List anything of note, or a quick summary. "I missed..." or "Merged as-is")
(`@support-maintainer-username`) please add feedback, and compare this review to
the average maintainer review.
Tip: There are tools available to assist with this task.
It is your responsibility to set up any necessary meetings to discuss your progress with your support maintainer, as well as your manager. These can be at any increment that is right for you.
When you're ready to make it official
When reviews have accumulated, and recent reviews consistently fulfill maintainer responsibilities, any maintainer can take the next step. The trainee should also feel free to discuss their progress with their manager or any maintainer at any time.
-
Create a merge request updating your team member entry proposing yourself as a maintainer for the chosen project. Indicate your selected project and maintainer type: -
design.gitlab.com: maintainer Figma
-
design.gitlab.com: maintainer UX
-
gitlab-svgs: maintainer Figma
-
-
Create a merge request for CODEOWNERS of design.gitlab.com
orgitlab-svgs
, adding yourself accordingly, and ask a maintainer to review it.- As maintainer, you must keep relying on others for the expertise they have that you don't. In the MR description, highlight the efforts that showcase your results at a maintainer-level, what skills you want to continue working on, and add a link to this issue. (Example).
-
design.gitlab.com CODEOWNERS file -
gitlab-svgs CODEOWNERS file
-
Ask a current project owner or maintainer to change your role on the project to Maintainer. -
After your team member entry merge request has merged, ask your manager to share the news in the following: -
UX Weekly -
Engineering week in review -
#ux-maintainers and #ux Slack channels
-
-
Keep reviewing, start merging 😃