Proposal for Maintainers: New Code Review process for contributing to GitLab, dogfooding the recently released Reviewers feature
Context
After the initial release of the Merge Request Reviewers feature in 13.5, several different ways of using this organically appeared.
After an issue and a MR proposal to update our Code Review process documentation, an effort was triggered to condense the feedback and propose an update that allows all reviewers of contributions towards the GitLab project to perform a consistent and efficient code review while dogfooding the Reviewers feature
Proposal
Please consult the slides below:
Code Review process for Contributing to GitLab - Dogfooding Reviewers feature PDF version
Update (March 4th - 1:53pm UTC): as suggested in a thread below, slides don't cover the merge. We'll add something along the following to the documentation update:
—
The last reviewer to approve and proceeds to merge the MR should stays listed in the Reviewers field.
Summary
Add reviewers as Reviewers. Reviewers remove themselves when finished reviewing.
Assignees are exclusively the authors and DRIs.
Authors re-add reviewers when ready to be re-reviewed.
Request for validation: Maintainers
Maintainers, as the group most affected by any change with the code review, we'd like to ask you to validate the proposal in the slides above.
Will that proposal allow you to conduct an efficient review of the code being proposed? Leave your thumbs up/down in the reactions of this issue.
Please and thank you.
Timeline
As described in the slides, we'll keep this proposal open for validation until Friday, March 12th 2021. If successful, the new process will be adopted at the start of 13.11, on Thursday, March 18th 2021.
Date | Event |
---|---|
Wednesday, March 3rd 2021 | Presented to all maintainers for validation. |
Thursday, March 4th 2021 | Share update during the company-wide Retrospective. |
Friday, March 12th 2021 | End of validation period. |
Monday, March 15th 2021 | New process communicated through Slack. Added to Engineering Week in Review. Notify Engineering Productivity team. |
Thursday, March 18th 2021 | Activation at the start of 13.11. Documentation updated. |