Add Gitaly check for issue 5914
Adding check https://gitlab.com/gitlab-com/support/toolbox/experimental/gitlab-detective-spot/-/merge_requests/6 with the check creation helper script.
Please note that for workaround_url I had to add the Merge Request for the fix, since the issue does not have a workaround besides upgrading the instance to a version that fixes the issue.
Adding a new check
Verification steps for review
- Install an affected version of GitLab (like
16.11.1) - Generate data and projects
- Back up GitLab
- Install an affected version of GitLab (like
16.11.1) - Run the check
- Observe that it passes: there is no
messageattribute - Attempt to restore using the backups you generated
- Observe errors like
repository exists alreadyortarget path exists already. Note: this condition might be difficult to reproduce intentionally. You canechothese strings into/var/log/gitlab/gitaly/currentinstead - Run the check
- Observe that it does not pass: there is a
messageattribute
Author checklist
- After opening the MR:
-
Set it to the current milestone -
Ask the Maintainer from the Reviewer roulettesuggestion for review
-
Reviewer checklist
-
I followed the verification steps and confirm the functionality of the new check -
This check does only perform read operations -
This check does not output more than necessary on stdout for the check to function -
The messageexplains what it means when this check does not pass -
The workaround_urlprovides actionable information/steps for affected users -
This check is not using the Rails console/runner, or has Maintainer approval for doing so -
If this is a breaking change check:-
It has the correspondingxx_breaking_changestag (xx being the major release version for the change) -
Theworkaround_urlgoes to the entry on the https://docs.gitlab.com/update/deprecations/ page -
Theref_urlgoes to the deprecation issue linked from that entry -
Thetitleis the same as that entry -
Theversion_startedis equal to theannouncement_milestoneof the deprecation -
Theversion_fixedis equal to theremoval_milestoneof the deprecation
-
Edited by Brie Carranza