Skip to content

Flip command exit code logic

Following the discussion in #104, this MR changes our current "exit code approach". It has proven a consistent source of confusion, and preliminary testing showed that "flipping the logic" is not particularly complex.

I was able to run a playbook generated from this branch against my instance without any problems – meaning spot barfing on the playbook. I have not yet validated that each individual logic flip is perfectly sound. I did verify a fair number, and one of each "category" (most checks have a similar format). Still, we'll need to verify each check individually – which is annoying, but a lot of them haven't had the thorough review of our current MR guidance yet, so it will benefit overall quality as well.

Merge request reports

Loading