Zoekt service definition in metrics catalog

Resolves gitlab-com/gl-infra/scalability#3559. Relates to https://gitlab.com/gitlab-com/gl-infra/capacity-planning-trackers/gitlab-com/-/issues/1701.

added featureaddition groupscalability teamScalability-Observability typefeature labels

assigned to @hmerscher

	2 Warnings
	This merge request is definitely too big (2525 lines changed), please split it into multiple merge requests.
	This merge request does not refer to an existing milestone.

If needed, you can retry the danger-review job that generated this comment.

Generated by Danger

changed the description

mentioned in merge request !7308 (closed)

added 19 commits

• 611d6e55...9b91fe58 - 15 commits from branch master
• 5de65003 - feat: zoekt service definition
• 0db873df - chore: make generate
• 18fca34f - feat(zoekt): skippedMaturityCriteria
• 53ebff05 - feat(zoekt): serviceDependencies

Compare with previous version

added 2 commits

• cab8affb - feat(zoekt): skippedMaturityCriteria
• 625dcfbe - feat(zoekt): serviceDependencies

Compare with previous version

marked this merge request as ready

changed title from Zoekt service definition to Zoekt service definition in metrics catalog

@reprazent could you review this one?

I was wondering, based on your comment here, given that zoekt could be added as a service dependency of the search service, would web, api, and sidekiq need to specify zoekt as a dependency considering that all of them already depend on search? Something like this af6a75be.

PS: I'm not sure if search, in fact, uses zoekt under the hood or if it only deals with ES.

requested review from @reprazent

added 2 commits

• c29da707 - feat(zoekt): skippedMaturityCriteria
• af1ea4ff - feat(zoekt): serviceDependencies

Compare with previous version

Thanks @hmerscher, I think we need to specify what we already know.

I've left a comment with what I think is missing. When we have all of that, we should get a bunch of the kubernetes related saturation metrics for free.

Then we can continue to the next step of specifying persistent volume claims as kubernetes resources so we can improve the saturation point for that.

Let me know if you need any help.

removed review request for @reprazent

added 1 commit

• b32b2dec - Kibana url for zoekt logs

Compare with previous version

added 40 commits

• b32b2dec...601dcd75 - 35 commits from branch master
• 9348dca7 - feat: zoekt service definition
• 7104dd8f - chore: make generate
• 0d54a7d5 - feat(zoekt): skippedMaturityCriteria
• 20820e79 - feat(zoekt): serviceDependencies
• 61172711 - Kibana url for zoekt logs

Compare with previous version

added 20 commits

• 61172711...cabdd84d - 13 commits from branch master
• d231961c - feat: zoekt service definition
• fb3f964c - chore: make generate
• 48ca531a - feat(zoekt): skippedMaturityCriteria
• af9e6cf6 - feat(zoekt): serviceDependencies
• 276e7ba0 - feat(zoekt): Kibana url for zoekt logs
• b16811ad - feat(zoekt): kube resources
• d47250b7 - chore: make generate

Compare with previous version

requested review from @reprazent

approved this merge request

Thanks @hmerscher, this looks good. But we'll still have to add the correct type label to the metrics. This needs to be done by adding the correct kubernetes labels to the resources.

I see the groundwork has been done in the chart in gitlab-org/cloud-native/charts/gitlab-zoekt#1 (closed), but I don't think that we've added the correct type, tier, ... labels to the resources when we implemented the chart. So to have all saturation points apply, we'll need to add those kubernetes labels.

That said, I think we can start by merging this hopefully making it a bit easier for you to work with this.

Thanks for doing this! It looks like there are a lot of skeletons in zoekt's closet, it might be a good idea to track all the things you're doing in the issue so we can repeat this process if we need to in the future .

Thanks a lot @reprazent

For reference:

• gitlab-org/cloud-native/charts/gitlab-zoekt#22
• https://gitlab.com/gitlab-com/gl-infra/capacity-planning-trackers/gitlab-com/-/issues/1701#note_1953270721

resolved all threads

started a merge train

merged

mentioned in commit 5fd919d8

This MR is included in version 3.104.0

The release is available on GitLab release.

Your semantic-release bot

mentioned in issue gitlab-org/cloud-native/charts/gitlab-zoekt#22