Skip to content

chore: replace hardcoded `sli_aggregations:` with recordingRuleRegistry

Gregorius Marco requested to merge mg-use-registry-for-sidekiq-dashboards into master

chore: replace hardcoded sli_aggregations: with recordingRuleRegistry

Some panels in the Sidekiq dashboards still use hardcoded sli_aggregations:gitlab_sli_sidekiq_execution_total_rate_5m. This format changes in Mimir so we use the recordingRuleRegistry to dynamically generate the rule name. In Mimir, the format would be sli_aggregations:gitlab_sli_sidekiq_execution_total:rate_5m

❯ ./test-dashboard.sh sidekiq/queue-detail.dashboard.jsonnet
Installed https://dashboards.gitlab.net/dashboard/snapshot/4qxz8UNdEuYcAJWptGbUmuH3v1wsL2OG - sidekiq: Queue Detail
❯ ./test-dashboard.sh sidekiq/shard-detail.dashboard.jsonnet
Installed https://dashboards.gitlab.net/dashboard/snapshot/kI5ZxMFa9IqJ66c3JAZM6H0JTSs6x2d3 - sidekiq: Shard Detail
Edited by Gregorius Marco

Merge request reports