Skip to content

feat: add the node-service aggregation

Bob Van Landuyt requested to merge bvl/mimir-node-service-aggregation into master

feat: add the node-service aggregation

This adds an aggregation set per node for a service. This aggregation is used on the top in gitaly's node-dashboard.

https://dashboards.gitlab.net/d/gitaly-host-detail/gitaly3a-host-detail?from=now-6h%2Fm&to=now%2Fm&var-PROMETHEUS_DS=e58c2f51-20f8-4f4b-ad48-2968782ca7d6&var-environment=gprd&var-stage=main&orgId=1

Though the dashboard is currently empty because of a label mismatch: gitlab-com/gl-infra/scalability#2700 (comment 1827690451).

To make it so we don't generate recording rules for services that we don't need a node-aggregation for, we've added the enabledForService predicate to the AggregationSet concept.

The last aggregation to tackle in gitlab-com/gl-infra/scalability#2475 (closed)

Merge request reports