fix: Adjusts the contract for dynamic configurations
- Some metrics are reliant on data from a configuration that is out of our control.
- With some services allocating limits upon us that we cannot query, we must instead derive the boundaries ourselves.
- This change introduces a concept where we must leverage a recording rule or alternatively, send a string, to complete the evaluation of the target metric
- These are noted with comments above the query to alert the consumer of
the metric of this requirement
- Allocating that recording rule is the responsibility of the customer
- An example of how this is accomplished is found in the
gitlab-metrics-config.libsonnetfile - An example of how this is accomplished via a recording rule can be found here: https://gitlab.com/gitlab-com/gl-infra/gitlab-dedicated/instrumentor/-/merge_requests/2658/diff
- I note this is a fix versus a breaking change as the usage of these metrics are quite low and consumed only by team dedicated at the moment
- While I'm mucking around in the memory specific item, adjusting some variable names and language for clarity
Contributes towards:
Edited by John Skarbek