Skip to content

chore: Removed old service apdex/ops/saturation rules that are not in service.

Stephanie Jackson requested to merge remove-old-apdex-rules into master

Related to gitlab-com/gl-infra/scalability#2584 (closed).

As part of an audit of recording rules, I found three files in rules that create a bunch of recording rules that appear not to be used anywhere else. They're all several years old and one of them (the saturation one) appears to do something like tamland.

I suspect we can just remove these, but I'm tagging Andrew and Bob as reviewers to get them to confirm for me.

Proof that they're not used anywhere else.

Feel free to appreciate my awesome bash skillz.

stejacks@atlas~/projects/gitlab-com/runbooks/rules (master) $ for I in grep record service* | grep -v #| awk '{print $4}' for> do for> echo $I for> cd .. for> git grep $I for> cd rules for> done

gitlab_component_apdex:ratio:avg_over_time_1w rules/service_component_apdex.yml: - record: gitlab_component_apdex:ratio:avg_over_time_1w gitlab_component_apdex:ratio:stddev_over_time_1w rules/service_component_apdex.yml: - record: gitlab_component_apdex:ratio:stddev_over_time_1w gitlab_component_ops:rate:avg_over_time_1w rules/service_component_ops_rate.yml: - record: gitlab_component_ops:rate:avg_over_time_1w gitlab_component_ops:rate:stddev_over_time_1w rules/service_component_ops_rate.yml: - record: gitlab_component_ops:rate:stddev_over_time_1w gitlab_component_saturation:ratio:avg_over_time_1w rules/service_saturation.yml: - record: gitlab_component_saturation:ratio:avg_over_time_1w rules/service_saturation.yml: predict_linear(gitlab_component_saturation:ratio:avg_over_time_1w[1w], 86400 * 14) rules/service_saturation.yml: predict_linear(gitlab_component_saturation:ratio:avg_over_time_1w[1w], 86400 * 30) gitlab_component_saturation:ratio:stddev_over_time_1w rules/service_saturation.yml: - record: gitlab_component_saturation:ratio:stddev_over_time_1w gitlab_component_saturation:ratio:predict_linear_2w rules/service_saturation.yml: - record: gitlab_component_saturation:ratio:predict_linear_2w gitlab_component_saturation:ratio:predict_linear_30d rules/service_saturation.yml: - record: gitlab_component_saturation:ratio:predict_linear_30d

Merge request reports