Fix sidekiq SLI on stage group error budget dashboard
- Fix sidekiq SLI panels on error budget stage group dashboard not showing any series. This broke because
aggregationSets.shardComponentSLIs
is hardcoded insliOverviewMatrixRow
function (https://gitlab.com/gitlab-com/runbooks/-/blob/e0352a3be6005d1ae0ceac205d5a361e33c132eb/libsonnet/gitlab-dashboards/metrics_catalog_dashboards.libsonnet#L89). This function is also called from stage group dashboards which needs to useaggregationSets.serviceComponentStageGroupSLIs
instead. source - Fix
expectMultipleSeries
flag not passed in service dashboard. This effectively sets line width to 1 instead of 2 (thinner line because we have multiple series from each shard in the dashboard) - Added
featureCategory: 'not_owned'
forsidekiq_queueing
so it doesn't show up in error budget's SLI panels and not counted in error budget attribution. Also removessidekiq_queueing
fromignored_components
Snapshots to test:
- https://dashboards.gitlab.net/dashboard/snapshot/vC6VFiXv15vsjaGw1LXA0o2buj3R40gM - Sidekiq overview dashboard
- https://dashboards.gitlab.net/dashboard/snapshot/FuCOrlm8VYjoENA2aWXxePQNSJIx9wMN?orgId=1 - stage group error budget dashboard
Edited by Gregorius Marco