Skip to content

Filter before matching SLIs to allow for duplicate SLI names.

Stephanie Jackson requested to merge registry-sli-server-fix into master

Resolves gitlab-com/gl-infra/scalability#1620 (closed).

Currently, the error budget detail dashboard for package is missing two SLIs, one for load balancer and one for server. This is because the jsonnet for this dashboard currently creates an object using object.fromPairs that removes any duplicates, and thus is matching only the first server entry.

This MR changes that to filter out the correct SLIs for the stage group first, which allows for duplicates.

Spot testing across multiple different dashboards shows that this works correctly, but it's a fairly significant change that is likely going to cause SLIs to show up in several places that weren't there before, so happy for additional feedback.

Although I suspect these won't still be valid by the time anyone looks at this...

Installed https://dashboards.gitlab.net/dashboard/snapshot/DoOfyNqgsnqdZMdbBWemiyMvOVSM61qj - stage-groups: Five Minute Production App: group error budget detail
Installed https://dashboards.gitlab.net/dashboard/snapshot/NLgRZqdk5huQ5Yol8761hFloip4Pf3SP - stage-groups: Adoption: group error budget detail
Installed https://dashboards.gitlab.net/dashboard/snapshot/iHoVmicbkNdSEb9Ucr5woU0KnG4CamcK - stage-groups: Anti-Abuse: group error budget detail
Installed https://dashboards.gitlab.net/dashboard/snapshot/3wK9OysBg0O1H7KcWkQDKRt0E4f5XtDx - stage-groups: Applied Machine Learning: group error budget detail
Installed https://dashboards.gitlab.net/dashboard/snapshot/6Unyiy2QQxF5q3Y5PTbnhypRb22PufKn - stage-groups: Authentication & Authorization: group error budget detail
Installed https://dashboards.gitlab.net/dashboard/snapshot/AWOaK1Te6mkqBW38N0YZlsyHFrPZxTBG - stage-groups: Certify: group error budget detail
Installed https://dashboards.gitlab.net/dashboard/snapshot/a51lLCoHVkB9GmN11NV9meQ2MvbBiZZC - stage-groups: Code Review: group error budget detail
Installed https://dashboards.gitlab.net/dashboard/snapshot/iB1kRkBR3VoDahxDZfIkl4t2G4QkdCGu - stage-groups: Compliance: group error budget detail
Installed https://dashboards.gitlab.net/dashboard/snapshot/6kwj9huRq49FRMu9695pUk9Ya1NTtw0Y - stage-groups: Composition Analysis: group error budget detail
Installed https://dashboards.gitlab.net/dashboard/snapshot/hk7jiM8tlTT1Y1bVOy0C1t6sNOci0pRN - stage-groups: Configure: group error budget detail
Installed https://dashboards.gitlab.net/dashboard/snapshot/X5txVKQdR6L8m2YRMKzqbfet93AjqHHw - stage-groups: Container Security: group error budget detail
Installed https://dashboards.gitlab.net/dashboard/snapshot/3CA2G4os9J3b3yzkSI6GLDHEQCtDC2lv - stage-groups: Conversion: group error budget detail
Installed https://dashboards.gitlab.net/dashboard/snapshot/vQKxilkVl0V7kxP7lGOf7tFVCI2p4whC - stage-groups: Database: group error budget detail
Installed https://dashboards.gitlab.net/dashboard/snapshot/Rr5r3CjpVDhZhhjqLErDQnmAx0ecumHw - stage-groups: DataOps: group error budget detail
Installed https://dashboards.gitlab.net/dashboard/snapshot/i9qQnq9rvzYUNw7tw0lMxuaIT19L8ICo - stage-groups: GitLab Dedicated: group error budget detail
Installed https://dashboards.gitlab.net/dashboard/snapshot/6GqBxCmjuT4hCbXcJq4nRiHAtFx4BO9D - stage-groups: Delivery: group error budget detail
Installed https://dashboards.gitlab.net/dashboard/snapshot/w0ERREmlTkhGrSYbYT8xpGPEC8pAyHBO - stage-groups: Distribution:Build: group error budget detail
Installed https://dashboards.gitlab.net/dashboard/snapshot/noKMfC2psqmBVDL3FmF5lHY5CkRvruiG - stage-groups: Distribution:Deploy: group error budget detail
Installed https://dashboards.gitlab.net/dashboard/snapshot/dLdBDnSPXAqy90u7xrt957HPWwIGgaXR - stage-groups: Dynamic Analysis: group error budget detail
Installed https://dashboards.gitlab.net/dashboard/snapshot/ghwf5AsAQBMAblgTsKJ5TlKCRNsDMgvC - stage-groups: Editor: group error budget detail
Installed https://dashboards.gitlab.net/dashboard/snapshot/eYXD0yCY05L1KFqnPjZLH6dH45NncoFS - stage-groups: Expansion: group error budget detail
Installed https://dashboards.gitlab.net/dashboard/snapshot/DkO1UrrtpHxElS0f25WidxHP6xSoY5U9 - stage-groups: Foundations: group error budget detail
Installed https://dashboards.gitlab.net/dashboard/snapshot/bsYLb499iyRMekcnxBinYbqTQz8Chp83 - stage-groups: Fulfillment Platform: group error budget detail
Installed https://dashboards.gitlab.net/dashboard/snapshot/lP6KAGqL79CHpfljcvQ5uNr0Ir3IBFFs - stage-groups: Geo: group error budget detail
Installed https://dashboards.gitlab.net/dashboard/snapshot/UXLu2rA452pJbF4gSBjZvqe9FZk0hNHk - stage-groups: Gitaly: group error budget detail
Installed https://dashboards.gitlab.net/dashboard/snapshot/RR5GpFYHEMMVjO4jcdG4ohJGXw5yHuKl - stage-groups: Global Search: group error budget detail
Installed https://dashboards.gitlab.net/dashboard/snapshot/2oPCrrjy4MtcKpISHt4kNon2V5RBDi6K - stage-groups: Import: group error budget detail
Installed https://dashboards.gitlab.net/dashboard/snapshot/5bwsaTeB9Zw6IWk5jV6FR7SNqx5Vyw91 - stage-groups: Integrations: group error budget detail
Installed https://dashboards.gitlab.net/dashboard/snapshot/vtTBgsFLwxqxrvx30Bu5AztkVKsgk7BB - stage-groups: Memory: group error budget detail
Installed https://dashboards.gitlab.net/dashboard/snapshot/jiTlUnEe7dfEMkacVSJizWIK6VALVfYJ - stage-groups: MLOps: group error budget detail
Installed https://dashboards.gitlab.net/dashboard/snapshot/Ks9zcj2WZF0jGXfx5caANghLfPXg8nmv - stage-groups: DevOps for Mobile Apps: group error budget detail
Installed https://dashboards.gitlab.net/dashboard/snapshot/eCilM7z3kZgWnABC177tVptZC2iIS5a8 - stage-groups: Observability: group error budget detail
Installed https://dashboards.gitlab.net/dashboard/snapshot/7ibt130A93FlHmD0DkPFtqJEeek3TwjQ - stage-groups: Optimize: group error budget detail
Installed https://dashboards.gitlab.net/dashboard/snapshot/OQ5I63P1OZMCFRzy496A9fnKzlrY116P - stage-groups: Package: group error budget detail
Installed https://dashboards.gitlab.net/dashboard/snapshot/SH4ZTzhZA5dXuB01QadwFkarZtHUQeDM - stage-groups: Pipeline Authoring: group error budget detail
Installed https://dashboards.gitlab.net/dashboard/snapshot/I5cxyPjKXOy8bnUn7S6WMc2kVDmrUQHl - stage-groups: Pipeline Execution: group error budget detail
Installed https://dashboards.gitlab.net/dashboard/snapshot/hyiIAC1D7dNh8WyAJkW429gDrr7X0QFo - stage-groups: Pipeline Insights: group error budget detail
Installed https://dashboards.gitlab.net/dashboard/snapshot/X1O1KWODcJTBWQTkBx8DObdZAhf9n0lh - stage-groups: Product Intelligence: group error budget detail
Installed https://dashboards.gitlab.net/dashboard/snapshot/wzh9iW3gb33WDH1CgLBIGLSq5JmYG6vI - stage-groups: Product Planning: group error budget detail
Installed https://dashboards.gitlab.net/dashboard/snapshot/F9JWdSht5PeziXX63r8RPFgRKiigFpcr - stage-groups: Project Management: group error budget detail
Installed https://dashboards.gitlab.net/dashboard/snapshot/5I614gL2lTAdzTpnbtcLSPlWBnvZgqaz - stage-groups: Provision: group error budget detail
Installed https://dashboards.gitlab.net/dashboard/snapshot/N5sMSc27TAVDX2a7s2rxcvvebJcjD64j - stage-groups: Purchase: group error budget detail
Installed https://dashboards.gitlab.net/dashboard/snapshot/9bB0efkFN4wDIRnQJ48WqXR8Tgp0xvIk - stage-groups: Release: group error budget detail
Installed https://dashboards.gitlab.net/dashboard/snapshot/3Fih3GwdJyNwb6Ui5gNiVLGtXa4v1WPO - stage-groups: Respond: group error budget detail
Installed https://dashboards.gitlab.net/dashboard/snapshot/GJ6Z0tDFlq5SVefSq1xxkuZUdJmczRVh - stage-groups: Runner: group error budget detail
Installed https://dashboards.gitlab.net/dashboard/snapshot/2NAMEbYYxgCBknCiNAITe1JeLyny8jsS - stage-groups: Scalability: group error budget detail
Installed https://dashboards.gitlab.net/dashboard/snapshot/uJGIa6nCEmQ901wJ5cwJ8feTX3ZedT2y - stage-groups: Sharding: group error budget detail
Installed https://dashboards.gitlab.net/dashboard/snapshot/V7mN6A4VQI6u5aPPxlzsgaExxj7wsy2b - stage-groups: Source Code: group error budget detail
Installed https://dashboards.gitlab.net/dashboard/snapshot/LR879Y2hfrDc3Zzbt0k6Fa4YUWbwfZ63 - stage-groups: Static Analysis: group error budget detail
Installed https://dashboards.gitlab.net/dashboard/snapshot/RXL3S6jJsMouqpLV7TVqnQAMSDW6A1pt - stage-groups: Threat Insights: group error budget detail
Installed https://dashboards.gitlab.net/dashboard/snapshot/Vtn6Wj1lyvx9OCXGGBKDmLgBkaCBIHto - stage-groups: Utilization: group error budget detail
Installed https://dashboards.gitlab.net/dashboard/snapshot/AYcdPMAG544x6uAt0lVpqmwIR4PN2erN - stage-groups: Vulnerability Research: group error budget detail
Installed https://dashboards.gitlab.net/dashboard/snapshot/385t3fKm3pRfOx882HzDFIgkEG063iz1 - stage-groups: Workspace: group error budget detail

Merge request reports