Skip to content

chore: Use metrics separated with a _ instead of a :

Bob Van Landuyt requested to merge bvl-use-new-metrics into master

This is second first step in switching to metrics separated with an _ as recommended in the Prometheus best practices:

Note: The colons are reserved for user defined recording rules. They should not be used by exporters or direct instrumentation.

https://prometheus.io/docs/concepts/data_model/#metric-names-and-labels

This starts using the metrics that are currently being emitted from the applications, since:

Currently the application is emitting both versions: separated with _ and separated with :. This starts using the metrics with a _. After we merge this, we can remove the old version from the application.

For gitlab-com/gl-infra/scalability#1760 (closed)

new metrics available in Prometheus

Edited by Bob Van Landuyt

Merge request reports