Skip to content

Always expand all services a saturation point applies to

Sean McGivern requested to merge always-expand-all-saturation-services into master

open_fds was the only saturation point using allExcept, which expanded to a negated selector in Prometheus, and a nested object in JSON. This doesn't work well for Tamland, which assumes the list of services will always be fully expanded.

As this was only used in one place, just remove the option to use allExcept entirely. Instead, metricsCatalog.findServicesExcluding can be used to much the same effect.

See https://gitlab.com/gitlab-com/gl-infra/tamland/-/blob/2e1c0d9572daac8f15fdea4d774d6bfb4a98a129/saturation.json#L1189-1194.

Merge request reports