chore(teams): send Growth error budget reports to #s_growth

Serhii Yarynovskyirequested to merge
growth-consolidate-error-budget-slack-channel into master

What

Points the weekly error budget Slack report for the three Growth stage groups at #s_growth instead of their per-group channels.

acquisition, activation, and engagement each had slack_error_budget_channel set to g_acquisition / g_activation / g_engagement. All three now read s_growth. The engagement entry was using the list form, so it is normalized to the scalar form to match the other two.

Nothing else changes. name, product_stage_group, send_error_budget_weekly_to_slack, ignored_components, and cloud_cost are untouched, and the three teams stay separate with separate error budgets.

Why

Growth is consolidating its per-group Slack channels (#g_acquisition, #g_activation, #g_engagement) into the stage channel #s_growth. Those channels are going away, so the reports need somewhere to land.

The move is reversible. If per-group channels are needed again later, they can be recreated and this reverted.

Expected behaviour after merge

Three reports will post into #s_growth every Monday, one per stage group — not one combined report. The groups remain distinct teams in the catalog, so this is correct. Please don't "fix" it later.

Merge prerequisite

The Growth team needs to run /invite @error_budget_report in #s_growth first. Without it the Monday report silently fails to post. Marked as Draft until that is done.

Verification

Run locally against this branch:

  • make validate-service-catalog — passes.
  • yamllint services/teams.yml — passes. The comment-spacing warnings it prints are pre-existing and are not on the changed lines.
  • Reproduced the validate-service-catalog-schema CI job: compiled services/raw-catalog.jsonnet with scripts/compile_jsonnet.rb and validated the result against services/service-catalog-schema.json with ajv — reported valid.
  • Inspected the compiled catalog: all three teams resolve to slack_error_budget_channel: "s_growth" with send_error_budget_weekly_to_slack: true.

References

Merge request reports