Skip to content

Resolve "[Eng] Fix local errors on localized pages"

John Arias Castillo requested to merge 132-eng-fix-local-errors-on-localized-pages into main

Step 1: What is changing in this MR?

404 Errors - Message in the console

A message in the console will be displayed when the current page does not have localized pages

image

Http Calls and Undefined errors

The LanguageSelector and the Footer components were calling the same getPageAvailableLanguages method, making again the same https requests. Now the Footer does the calls and pass the results as a prop to the LanguageSelector component

Navigation component does not check availableLanguages anymore, now it does a validation between the localStorage and the pathName. This fix solves the undefined errors in console and avoid calling multiple times the same localization URL's.

Other refactors

  • Refactor LanguageSelector component to avoid console messages

Review app

Review App

Step 2: Ensure that your changes comply with the following, where applicable:

  • I, the Assignee, have run Axe tools on any updated pages, and fixed the relevant accessibility issues.
  • These changes meet a specific OKR or item in our Quarterly Plan.
  • These changes work on both Safari, Chrome, and Firefox.
  • These changes have been reviewed for Visual Quality Assurance and Functional Quality Assurance on Mobile, Desktop, and Tablet.
  • These changes work with our Google Analytics and SEO tools.
  • These changes have been documented as expected.

Step 3: Add the appropriate labels for triage

This MR will have dex-approval::2-standard automatically applied, but please update it as follows. If deciding between two levels, go with the higher of the two: https://gitlab.com/gitlab-com/www-gitlab-com/blob/master/sites/handbook/source/handbook/marketing/digital-experience/marketing-site-approval-process/index.html.md

Step 4: Tag the appropriate person for review

Depending on which label is used, you may tag the following people as a Reviewer on this MR: https://about.gitlab.com/handbook/marketing/digital-experience/marketing-site-approval-process/#step-3-tag-the-appropriate-people-for-review

Closes #132 (closed), buyer-experience#2531 (closed), buyer-experience#2545 (closed)

Edited by John Arias Castillo

Merge request reports