Skip to content

Resolve "[ENG] [Bug... or kind of] Fix duplicated ID's, solve FAQ routing"

Alvise requested to merge Alvisex/buyer-experience:3858-solve-faq-id-duplicated into main

Step 0: Context?

The Addons cards use a header with an anchor, when the title is the same as one in the FAQ sections (#compute-minutes), this generates a duplicated ID and therefore a wrong behavior.

Step 1: What is changing in this MR?

This commit adds a suffix to this card header (-addon) to prevent any duplicated ID

Default image

But there is no duplication if the ID is not the same (as in the JP version).

ja-jp image
With error Expected
default with duplication ja-jp version
Production Review app
https://about.gitlab.com/pricing/#compute-minutes WIP

Step 2: Ensure that your changes comply with the following, where applicable:

  • I, the Assignee, have run Axe tools on any updated pages, and fixed the relevant accessibility issues.
  • These changes work on both Safari, Chrome, and Firefox.
  • These changes have been reviewed for Visual Quality Assurance and Functional Quality Assurance on Mobile, Desktop, and Tablet.
  • These changes work with our Google Analytics and SEO tools.
  • These changes have been documented as expected.

Step 3: Ensure that your changes don't cause regressions on key pages, where applicable:

Production Review app
https://about.gitlab.com/ WIP
https://about.gitlab.com/pricing/ WIP
https://about.gitlab.com/ja-jp/pricing/ WIP

Closes #3858

Edited by Alvise

Merge request reports