Skip to content

Resolve "[ENG] Public Sector update"

Miguel Duque requested to merge 3772-eng-public-sector-update into main

Step 1: What is changing in this MR?

  • Updates BySolutionValueProp to use the SolutionsVideoModal either on the title or as a cta button in a card
  • Updates /components/solutions/business-showcase.vue to take on styles from contentful entry and adapt it to figma design
  • Update ByIndustryCarouselComponent component with subheader and cta link
  • Adapts /components/solutions/templates/industry to the NextStep new implementation

For releasing, publish all draft entries nested inside the Public Sector page entry: https://app.contentful.com/spaces/xz1dnu24egyd/entries/51DJ4HkNueANSrcfSMUEI8

Production Review app
https://about.gitlab.com/solutions/public-sector https://3772-eng-public-sector-update.about.gitlab-review.app/solutions/public-sector

Step 2: Ensure that your changes comply with the following, where applicable:

  • I, the Assignee, have run Axe tools on any updated pages, and fixed the relevant accessibility issues.
  • These changes work on both Safari, Chrome, and Firefox.
  • These changes have been reviewed for Visual Quality Assurance and Functional Quality Assurance on Mobile, Desktop, and Tablet.
  • These changes work with our Google Analytics and SEO tools.
  • These changes have been documented as expected.

Step 3: Ensure that your changes don't cause regressions on key pages, where applicable:

Production Review app
https://about.gitlab.com/ https://3772-eng-public-sector-update.about.gitlab-review.app/
https://about.gitlab.com/ja-jp/ https://3772-eng-public-sector-update.about.gitlab-review.app/ja-jp
https://about.gitlab.com/pricing/ https://3772-eng-public-sector-update.about.gitlab-review.app/pricing
https://about.gitlab.com/ja-jp/pricing/ https://3772-eng-public-sector-update.about.gitlab-review.app/ja-jp/pricing
https://about.gitlab.com/sales/ https://3772-eng-public-sector-update.about.gitlab-review.app/sales
https://about.gitlab.com/gitlab-duo/ https://3772-eng-public-sector-update.about.gitlab-review.app/gitlab-duo
https://about.gitlab.com/enterprise/ https://3772-eng-public-sector-update.about.gitlab-review.app/enterprise
https://about.gitlab.com/platform/ https://3772-eng-public-sector-update.about.gitlab-review.app/platform
https://about.gitlab.com/free-trial/ https://3772-eng-public-sector-update.about.gitlab-review.app/free-trial

Build Variables:

  • Use Contentful Preview API

Related to #3772 (closed)

Edited by Miguel Duque

Merge request reports