Skip to content

fix: Programatically update GLM params

Javier Garcia requested to merge 3705-glm-parameters-for-free-trial-cta-on-next-steps-are-same into main 
If a user clicks start trial on the following pages, these are the values that should be applied:

about.gitlab.com/pricing/
GLM_source=about.gitlab.com
GLM_content=pricing

about.gitlab.com
GLM_source=about.gitlab.com
GLM_content=/ (note, the home page is unique so if possible it would be great to have a one-off value of home-page if possible)

about.gitlab.com/gitlab-duo/
GLM_source=about.gitlab.com
GLM_content=gitlab-duo

Step 1: What is changing in this MR?

  • create mixins/edit-query-params.mixin.ts that adds this.$route.path to glm_content on CTAs where glm_source is currently about.gitlab.com
  • add this to the functional check on the primary CTA in NextStep and NextStepAlt
Production Review app
https://about.gitlab.com/ https://3705-glm-parameters-for-free-trial-cta-on-next-steps-are-same.about.gitlab-review.app/

It would help if you validated this against high-value pages first (anything P1), then we can focus on less valuable pages

  • wrote as a mixing so that it could be used in other CTAs among other components! If the pattern isn't matched, it would simply return the original URL value. There are some safety checks that we can continue to build out so that only the first properties get added to the right links. I believe this is a good first iteration.

Step 2: Ensure that your changes comply with the following, where applicable:

  • I, the Assignee, have run Axe tools on any updated pages, and fixed the relevant accessibility issues.
  • These changes work on both Safari, Chrome, and Firefox.
  • These changes have been reviewed for Visual Quality Assurance and Functional Quality Assurance on Mobile, Desktop, and Tablet.
  • These changes work with our Google Analytics and SEO tools.
  • These changes have been documented as expected.

Build Variables:

  • Use Contentful Preview API

Closes #3705 (closed)

Edited by Javier Garcia

Merge request reports